Commit Graph

4922 Commits

Author SHA1 Message Date
denchat
1bb8044a52
Fix removing entire declaration
Fix removing the entire declaration because at line 999 there is one.
CI Error in macOS.
2021-04-10 23:10:55 +07:00
denchat
0e3c282f06
Try remove FMT_INSTANTIATION_DEF_API
Try remove FMT_INSTANTIATION_DEF_API from extern template
2021-04-10 23:04:12 +07:00
denchat
70258cbe27
Move FMT_INSTANTIATION_DEF_API deletion into WIN32 2021-04-09 02:23:33 +07:00
denchat
81aaff7534
Fix incorrect namespace in previous commit 2021-04-09 02:05:19 +07:00
denchat
28882fa1e3
Add the template instantiation declaration
Add the template instantiation **declaration** of `basic_data<void>`
the the template instantiation **definition** is in `format.cc`
2021-04-09 01:50:08 +07:00
denchat
0ad4dadcba
Clang keeps complain it ignores __declspec(dllexport)
Clang keeps complain it ignores __declspec(dllexport) in format.cc's instantiation of "detail::basic_data<void>;"

```
C:/Users/User/AppData/Roaming/fmt-master/src/format.cc:58:17: warning: 'dllexport' attribute ignored on explicit instantiation definition [-Wignored-attributes]
template struct FMT_INSTANTIATION_DEF_API detail::basic_data<void>;
                ^
C:/Users/User/AppData/Roaming/fmt-master/include\fmt/core.h:228:37: note: expanded from macro 'FMT_INSTANTIATION_DEF_API'
#  define FMT_INSTANTIATION_DEF_API FMT_API
                                    ^
C:/Users/User/AppData/Roaming/fmt-master/include\fmt/core.h:210:32: note: expanded from macro 'FMT_API'
#    define FMT_API __declspec(dllexport)
                               ^
1 warning generated.
```

I guess we have to make an explicit instantiation definition of `basic_data<void>` in format.cc (without `__declspec(dllexport)` )
and make an explicit instantiation declaration (aka `extern template`) in format.h instead
2021-04-09 01:44:07 +07:00
Victor Zverovich
5a8bf1f6a3 Workaround hexfloat inconsistency on windows (#2205) 2021-04-07 11:20:08 -07:00
Elliot
78776ee4e2
Fix a conditional expression is constant warning #2210 (#2211) 2021-04-07 10:42:11 -07:00
jstaahl
266107f57c
constexpr uint128_wrapper (#2215)
* constexpr uint128_wrapper

* change FMT_CONSTEXPR to constexpr

* clang format

Co-authored-by: Jake Staahl <jstaahl@snapchat.com>
2021-04-06 22:07:01 -07:00
Alexey Ochapov
2e0d64cf2f specify size for prefixes static data 2021-04-06 17:07:14 -07:00
Victor Zverovich
95da484727 Fix a link 2021-04-03 09:14:52 -07:00
Victor Zverovich
06b3a1000c Add support for time points with arbitrary durations (#2208) 2021-04-02 11:17:14 -07:00
Victor Zverovich
dac42f52b2 Inline fallback is_constant_evaluated 2021-04-01 10:42:09 -07:00
Victor Zverovich
7c43f8b896 Don't use strlen at compile time (#2205) 2021-04-01 10:04:21 -07:00
Jason Cobb
c62e4c30f4 Make buffer_appender default-constructible when back_insert_iterator is 2021-04-01 09:52:44 -07:00
Victor Zverovich
0d6b70d96b Install gcc 8 2021-04-01 09:19:36 -07:00
Victor Zverovich
15c10b0c66 Add speech synthesis support 2021-04-01 09:19:36 -07:00
Billy Donahue
308510eb4f "Use" fwrite result (workaround for warn_unused_result)
Fixes #2185
2021-03-31 08:31:35 -07:00
Victor Zverovich
afe23e7f10 Don't call fileno on NULL file in tests (#2196) 2021-03-30 10:41:12 -07:00
Victor Zverovich
b49af043d7 Remove noexcept from file's move assignment 2021-03-30 09:51:25 -07:00
vtta
14848875bf
Fix: fmt::ostream cannot be moved while holding buffered data #2197 (#2198)
* Add a test case: move ostream while holding data

* Fix moving ostream while holding data

Co-authored-by: Junliang HU <jlhu@cse.cuhk.edu.hk>
2021-03-30 08:43:26 -07:00
Victor Zverovich
7d8c34018e
Update pull_request_template.md 2021-03-30 08:42:11 -07:00
Victor Zverovich
b966afcc7a Remove formattable 2021-03-28 14:21:12 -07:00
Victor Zverovich
ec5315a987 Use strlen when possible in fallback basic_string_view 2021-03-28 08:01:55 -07:00
Victor Zverovich
4f8778bab9 Inline basic_format_args's ctor 2021-03-28 07:32:17 -07:00
Yaser Afshar
e2d87548f8 user-defined constructor
user-defined constructor added to prevent Intel compilers
warnings. According to the standard, objects need to have a
user-defined constructor if instances are delcared const.
2021-03-28 06:56:14 -07:00
Yaser Afshar
f7151d384b Extra flag to prevent Intel compiler with Clang front-end warning of 'unknown attribute no_sanitize' 2021-03-28 06:56:14 -07:00
Victor Zverovich
0fb8ef8f79 Inline trivial argument handling functions 2021-03-27 19:05:39 -07:00
Victor Zverovich
1b23e25f95 Simplify formattability check 2021-03-27 18:57:18 -07:00
Victor Zverovich
35c71ff536 Only use -Og with optimizations disabled 2021-03-27 11:35:01 -07:00
Victor Zverovich
243d8bebd1 Enable minimal optimizations in debug mode 2021-03-27 08:40:07 -07:00
Chris White
9b34681d97
Work around xl compiler bug when nvcc preprocesses this file (#2190) 2021-03-27 06:05:49 -07:00
Vladislav Shchapov
4dc7170d21
Fix C++17 builds: (#2192)
- Fix C++17 Visual Studio builds.
- Use C++17 for `windows-2019` builds.
- Removed options for unsupported compiler (MSVC11).
- Removed options, not needed after enabling C++11+ features in gmock/gtest.
2021-03-26 06:19:43 -07:00
Victor Zverovich
9cb347b4b2 Simplify argument formatters 2021-03-21 09:31:46 -07:00
Ryan Sherlock
0f85a4683a
add default cases (#2186)
Adding default case for switch statements where the compilation
flag -Wswitch-default is present on the command line when spdlog
is included in external projects.

Signed-off-by: Ryan Sherlock <ryan.m.sherlock@gmail.com>
2021-03-19 16:56:52 -07:00
Victor Zverovich
417e1cee9e Stop using deprecated UDL templates 2021-03-19 08:34:55 -07:00
Victor Zverovich
f7e900e12e Simplify UDL definitions 2021-03-19 08:10:58 -07:00
Victor Zverovich
d9661c8f3b Mark grouping as deprecated 2021-03-19 07:54:57 -07:00
Victor Zverovich
14a2a64df4 Fix handling of formattable types with to_string_view (#2181) 2021-03-19 06:43:38 -07:00
Victor Zverovich
6ae402fd0b Fix handling of types with to_string_view and formatter specialization (#2180) 2021-03-18 11:25:43 -07:00
Victor Zverovich
a6408a3b09 Add args-test 2021-03-18 09:04:17 -07:00
Victor Zverovich
1147782c79 Fix an ambiguous call to check caused by ADL (#2184) 2021-03-17 20:59:36 -07:00
VZ
2f3f3862fa
Fix harmless MSVS warning about using undefined _MANAGED symbol (#2183)
Since the changes of 1305cbeb (Fix MSVC2019 error C2049 when compiling
with /clr (#1897), 2020-09-23), compiling fmt with MSVS 2019 resulted in

fmt\include\fmt\core.h(180,32): warning C4668: '_MANAGED' is not defined
as a preprocessor macro, replacing with '0' for '#if/#elif'.

when the (disabled by default) warning C4668 was enabled.

Fix this simply by checking if _MANAGED is defined before testing it.
2021-03-17 11:21:50 -07:00
Brainy0207
d0bded5988
Fix MSVC /clr builds (#2179) 2021-03-15 08:17:28 -07:00
Victor Zverovich
8308f52c2a Fix dynamic_format_arg_store::push_back comment 2021-03-15 07:10:28 -07:00
Victor Zverovich
6151d0dc1e Fix the comment 2021-03-14 09:26:18 -07:00
Victor Zverovich
5a1127b726 Don't wrap named arg in cref and clarify docs 2021-03-14 09:08:08 -07:00
moiwi
b8ff3c1820
optimize append (#2164) 2021-03-13 07:21:23 -08:00
Alexey Ochapov
c8d8b88223
fix GCC 7,8,9 warning about unused but set parameter (#2177) 2021-03-13 06:36:53 -08:00
Victor Zverovich
d28101878a Document ostream support limitation 2021-03-12 15:49:22 -08:00