External/fmt
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed all clang -Wsigned-enum-bitfield warnings

Browse Source 
Made enums involved in bitfields unsigned.

Used unsigned char specifically because gcc before 9.3 seems to have a bug where it warns about bitfields not being big enough to hold the enum, even though they are.
This commit is contained in:
Sean McBride 2022-03-04 15:42:13 -05:00
parent 5379063b54
commit 840b6856c5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/fmt/core.h
View File

@ -2014,11 +2014,11 @@ using format_args = basic_format_args<format_context>;
// We cannot use enum classes as bit fields because of a gcc bug // We cannot use enum classes as bit fields because of a gcc bug
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61414. // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61414.
namespace align { namespace align {
enum type { none, left, right, center, numeric }; enum type : unsigned char { none, left, right, center, numeric };
} }
using align_t = align::type; using align_t = align::type;
namespace sign { namespace sign {
enum type { none, minus, plus, space }; enum type : unsigned char { none, minus, plus, space };
} }
using sign_t = sign::type; using sign_t = sign::type;