From 840b6856c51f0d7b0d87b8bcd533301fe6757d95 Mon Sep 17 00:00:00 2001 From: Sean McBride Date: Fri, 4 Mar 2022 15:42:13 -0500 Subject: [PATCH] Fixed all clang -Wsigned-enum-bitfield warnings Made enums involved in bitfields unsigned. Used unsigned char specifically because gcc before 9.3 seems to have a bug where it warns about bitfields not being big enough to hold the enum, even though they are. --- include/fmt/core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/fmt/core.h b/include/fmt/core.h index 3feb2a7d..cce25f3d 100644 --- a/include/fmt/core.h +++ b/include/fmt/core.h @@ -2014,11 +2014,11 @@ using format_args = basic_format_args; // We cannot use enum classes as bit fields because of a gcc bug // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61414. namespace align { -enum type { none, left, right, center, numeric }; +enum type : unsigned char { none, left, right, center, numeric }; } using align_t = align::type; namespace sign { -enum type { none, minus, plus, space }; +enum type : unsigned char { none, minus, plus, space }; } using sign_t = sign::type;