External/yaml-cpp
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

issue_937: <rjk9w5><bugfix><build> Conditionally disabled -Weffc++ and -Wshadow for compilers with broken implementations

Browse Source
This commit is contained in:
Ryan Krattiger 2020-10-06 15:19:53 -05:00
parent 98acc5a887
commit c848ee3388
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
CMakeLists.txt
View File

@ -42,6 +42,12 @@ set(build-shared $<BOOL:${YAML_BUILD_SHARED_LIBS}>)
set(build-windows-dll $<AND:$<BOOL:${CMAKE_HOST_WIN32}>,${build-shared}>)
set(not-msvc $<NOT:$<CXX_COMPILER_ID:MSVC>>)
set(msvc-shared_rt $<BOOL:${YAML_MSVC_SHARED_RT}>)
set(not-intel $<NOT:$<CXX_COMPILER_ID:Intel>>)
set(not-gnu $<NOT:$<CXX_COMPILER_ID:GNU>>)
# -Weffc++ does not work correctly for some compilers
set(weffcpp-compatible $<AND:${not-intel},${not-gnu},${not-msvc}>)
# -Wshadow does not work correctly for some compilers
set(wshadow-compatible $<AND:${not-intel},${not-msvc}>)
if (NOT DEFINED CMAKE_MSVC_RUNTIME_LIBRARY)
set(CMAKE_MSVC_RUNTIME_LIBRARY
@ -93,7 +99,9 @@ endif()
target_compile_options(yaml-cpp
PRIVATE
$<${not-msvc}:-Wall -Wextra -Wshadow -Weffc++ -Wno-long-long>
$<${not-msvc}:-Wall -Wextra -Wno-long-long>
$<${wshadow-compatible}:-Wshadow >
$<${weffcpp-compatible}:-Weffc++>
$<${not-msvc}:-pedantic -pedantic-errors>
$<$<AND:${backport-msvc-runtime},${msvc-rt-mtd-static}>:-MTd>