run through clang's -Wrange-loop-analysis

Some range loops should not use references as they need to copy.

Signed-off-by: Rosen Penev <rosenp@gmail.com>

src/nodeevents.cpp

@@ -32,13 +32,12 @@ void NodeEvents::Setup(const detail::node& node) {
     return;
 
   if (node.type() == NodeType::Sequence) {
-    for (const auto& it : node)
+    for (auto element : node)
-      Setup(*it);
+      Setup(*element);
   } else if (node.type() == NodeType::Map) {
-    for (detail::const_node_iterator it = node.begin(); it != node.end();
+    for (auto element : node) {
-         ++it) {
+      Setup(*element.first);
-      Setup(*it->first);
+      Setup(*element.second);
-      Setup(*it->second);
     }
   }
 }
@@ -77,16 +76,15 @@ void NodeEvents::Emit(const detail::node& node, EventHandler& handler,
       break;
     case NodeType::Sequence:
       handler.OnSequenceStart(Mark(), node.tag(), anchor, node.style());
-      for (const auto& it : node)
+      for (auto element : node)
-        Emit(*it, handler, am);
+        Emit(*element, handler, am);
       handler.OnSequenceEnd();
       break;
     case NodeType::Map:
       handler.OnMapStart(Mark(), node.tag(), anchor, node.style());
-      for (detail::const_node_iterator it = node.begin(); it != node.end();
+      for (auto element : node) {
-           ++it) {
+        Emit(*element.first, handler, am);
-        Emit(*it->first, handler, am);
+        Emit(*element.second, handler, am);
-        Emit(*it->second, handler, am);
       }
       handler.OnMapEnd();
       break;