External/pugixml
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Optimize text_output_indent

Browse Source 
We now precompute indent length and have a fast path for lengths 0..4 that
avoids calling memcpy in a tight loop. This makes node output 20-30%
faster if indentation is enabled.

git-svn-id: https://pugixml.googlecode.com/svn/trunk@1018 99668b35-9821-0410-8761-19e4c4f06640
This commit is contained in:
Arseny Kapoulkine 2014-09-21 21:52:30 +00:00
parent 53550424d9
commit fff1991743
1 changed files with 46 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
src/pugixml.cpp
View File

@ -3269,10 +3269,47 @@ PUGI__NS_BEGIN
while (*s); while (*s);
} }
PUGI__FN void text_output_indent(xml_buffered_writer& writer, const char_t* indent, unsigned int depth) PUGI__FN void text_output_indent(xml_buffered_writer& writer, const char_t* indent, size_t indent_length, unsigned int depth)
{
switch (indent_length)
{
case 0:
break;
case 1:
{ {
for (unsigned int i = 0; i < depth; ++i) for (unsigned int i = 0; i < depth; ++i)
writer.write(indent); writer.write(indent[0]);
break;
}
case 2:
{
for (unsigned int i = 0; i < depth; ++i)
writer.write(indent[0], indent[1]);
break;
}
case 3:
{
for (unsigned int i = 0; i < depth; ++i)
writer.write(indent[0], indent[1], indent[2]);
break;
}
case 4:
{
for (unsigned int i = 0; i < depth; ++i)
writer.write(indent[0], indent[1], indent[2], indent[3]);
break;
}
default:
{
for (unsigned int i = 0; i < depth; ++i)
writer.write(indent, indent_length);
}
}
} }
PUGI__FN void node_output_attributes(xml_buffered_writer& writer, const xml_node& node, unsigned int flags) PUGI__FN void node_output_attributes(xml_buffered_writer& writer, const xml_node& node, unsigned int flags)
@ -3413,6 +3450,8 @@ PUGI__NS_BEGIN
PUGI__FN void node_output(xml_buffered_writer& writer, const xml_node& root, const char_t* indent, unsigned int flags, unsigned int depth) PUGI__FN void node_output(xml_buffered_writer& writer, const xml_node& root, const char_t* indent, unsigned int flags, unsigned int depth)
{ {
size_t indent_length = ((flags & (format_indent | format_raw)) == format_indent) ? strlength(indent) : 0;
xml_node node = root; xml_node node = root;
do do
@ -3420,8 +3459,8 @@ PUGI__NS_BEGIN
assert(node); assert(node);
// begin writing current node // begin writing current node
if ((flags & (format_indent | format_raw)) == format_indent) if (indent_length)
text_output_indent(writer, indent, depth); text_output_indent(writer, indent, indent_length, depth);
if (node.type() == node_element) if (node.type() == node_element)
{ {
@ -3460,8 +3499,8 @@ PUGI__NS_BEGIN
// write closing node // write closing node
if (node.type() == node_element) if (node.type() == node_element)
{ {
if ((flags & (format_indent | format_raw)) == format_indent) if (indent_length)
text_output_indent(writer, indent, depth); text_output_indent(writer, indent, indent_length, depth);
node_output_end(writer, node, flags); node_output_end(writer, node, flags);
} }