diff --git a/src/pugixml.cpp b/src/pugixml.cpp index 156a1f4..afce6e8 100644 --- a/src/pugixml.cpp +++ b/src/pugixml.cpp @@ -3930,17 +3930,11 @@ PUGI__NS_BEGIN ++s; break; case '"': - if (flags & format_attribute_single_quote) - writer.write('"'); - else - writer.write('&', 'q', 'u', 'o', 't', ';'); + writer.write('&', 'q', 'u', 'o', 't', ';'); ++s; break; case '\'': - if (flags & format_attribute_single_quote) - writer.write('&', 'a', 'p', 'o', 's', ';'); - else - writer.write('\''); + writer.write('&', 'a', 'p', 'o', 's', ';'); ++s; break; default: // s is not a usual symbol diff --git a/tests/test_write.cpp b/tests/test_write.cpp index 0410e82..36556e5 100644 --- a/tests/test_write.cpp +++ b/tests/test_write.cpp @@ -193,8 +193,8 @@ TEST_XML(write_escape, "text") doc.child(STR("node")).attribute(STR("attr")) = STR("<>'\"&\x04\r\n\t"); doc.child(STR("node")).first_child().set_value(STR("<>'\"&\x04\r\n\t")); - CHECK_NODE(doc, STR("'"& \"><>'\"&\r\n\t")); - CHECK_NODE_EX(doc, STR("<>'\"&\r\n\t"), STR(""), format_raw | format_attribute_single_quote); + CHECK_NODE(doc, STR("'"& \"><>'\"&\r\n\t")); + CHECK_NODE_EX(doc, STR("<>'\"&\r\n\t"), STR(""), format_raw | format_attribute_single_quote); } TEST_XML(write_escape_roundtrip, "text") @@ -208,8 +208,8 @@ TEST_XML(write_escape_roundtrip, "text") // Note: this string is almost identical to the string from write_escape with the exception of \r // \r in PCDATA doesn't roundtrip because it has to go through newline conversion (which could be disabled, but is active by default) - CHECK_NODE(doc, STR("'"& \"><>'\"&\n\t")); - CHECK_NODE_EX(doc, STR("<>'\"&\n\t"), STR(""), format_raw | format_attribute_single_quote); + CHECK_NODE(doc, STR("'"& \"><>'\"&\n\t")); + CHECK_NODE_EX(doc, STR("<>'\"&\n\t"), STR(""), format_raw | format_attribute_single_quote); } TEST_XML(write_escape_unicode, "")