External/pugixml
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Mark shallow copy as page shared to avoid reuse

Browse Source
This commit is contained in:
halx99 2021-10-01 08:45:25 +08:00
parent ffdc1a17e2
commit 83d487aa62
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/pugixml.cpp
View File

@ -2345,7 +2345,8 @@ PUGI__NS_BEGIN
size_t target_length = strlength(target); size_t target_length = strlength(target);
// always reuse document buffer memory if possible // always reuse document buffer memory if possible
if ((header & header_mask) == 0) return target_length >= length; if ((header & header_mask) == 0)
return target_length >= length;
// reuse heap memory if waste is not too great // reuse heap memory if waste is not too great
const size_t reuse_threshold = 32; const size_t reuse_threshold = 32;
@ -2367,6 +2368,9 @@ PUGI__NS_BEGIN
dest = source_length == 0 ? 0 : const_cast<char_t*>(source); dest = source_length == 0 ? 0 : const_cast<char_t*>(source);
header &= ~header_mask; header &= ~header_mask;
// since strcpy_insitu can reuse document buffer memory we need to mark both dest as shared
header |= xml_memory_page_contents_shared_mask;
return true; return true;
} }
else if (dest && strcpy_insitu_allow(source_length, header, header_mask, dest)) else if (dest && strcpy_insitu_allow(source_length, header, header_mask, dest))