External/pugixml
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Correct switch fallthrough warnings

Browse Source 
GCC 7.3.0 gave the following warning:
src/pugixml.cpp:10193:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
without these attributes.
This commit is contained in:
lmat 2018-03-10 11:42:45 -05:00
parent 9187e6500c
commit 6ffb11cd22
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/pugixml.cpp
View File

@ -10267,9 +10267,9 @@ PUGI__NS_BEGIN
if (_rettype == xpath_type_boolean) if (_rettype == xpath_type_boolean)
return _data.variable->get_boolean(); return _data.variable->get_boolean();
__attribute__ ((fallthrough));
} }
// fallthrough
default: default:
{ {
switch (_rettype) switch (_rettype)
@ -10402,9 +10402,9 @@ PUGI__NS_BEGIN
if (_rettype == xpath_type_number) if (_rettype == xpath_type_number)
return _data.variable->get_number(); return _data.variable->get_number();
__attribute__ ((fallthrough));
} }
// fallthrough
default: default:
{ {
switch (_rettype) switch (_rettype)
@ -10683,12 +10683,11 @@ PUGI__NS_BEGIN
case ast_variable: case ast_variable:
{ {
assert(_rettype == _data.variable->type()); assert(_rettype == _data.variable->type());
if (_rettype == xpath_type_string) if (_rettype == xpath_type_string)
return xpath_string::from_const(_data.variable->get_string()); return xpath_string::from_const(_data.variable->get_string());
__attribute__ ((fallthrough));
} }
// fallthrough
default: default:
{ {
switch (_rettype) switch (_rettype)
@ -10835,9 +10834,9 @@ PUGI__NS_BEGIN
return ns; return ns;
} }
__attribute__ ((fallthrough));
} }
// fallthrough
default: default:
assert(false && "Wrong expression for return type node set"); // unreachable assert(false && "Wrong expression for return type node set"); // unreachable
return xpath_node_set_raw(); return xpath_node_set_raw();