diff --git a/src/pugixml.cpp b/src/pugixml.cpp index ea6514b..e166142 100644 --- a/src/pugixml.cpp +++ b/src/pugixml.cpp @@ -4440,7 +4440,7 @@ PUGI__NS_BEGIN bool negative = (*s == '-'); - s += negative; + s += (*s == '+' || *s == '-'); bool overflow = false; diff --git a/tests/test_dom_traverse.cpp b/tests/test_dom_traverse.cpp index 1fbc317..c7408cb 100644 --- a/tests/test_dom_traverse.cpp +++ b/tests/test_dom_traverse.cpp @@ -1224,4 +1224,21 @@ TEST_XML(dom_as_ullong_hex_overflow, "") +{ + xml_node node = doc.child(STR("node")); + + CHECK(node.attribute(STR("attr1")).as_int() == 1); + CHECK(node.attribute(STR("attr1")).as_uint() == 1); + CHECK(node.attribute(STR("attr2")).as_int() == 10); + CHECK(node.attribute(STR("attr2")).as_uint() == 10); + +#ifdef PUGIXML_HAS_LONG_LONG + CHECK(node.attribute(STR("attr1")).as_llong() == 1); + CHECK(node.attribute(STR("attr1")).as_ullong() == 1); + CHECK(node.attribute(STR("attr2")).as_llong() == 10); + CHECK(node.attribute(STR("attr2")).as_ullong() == 10); +#endif +} \ No newline at end of file