External/pugixml
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Correctly set default visibility on non-windows compilers

Browse Source 
This fixes compilation of pugixml with -fvisibility=hidden. Without
this patch, one would get lots of unresolved symbols when consuming
pugixml as a shared library.
This commit is contained in:
Milian Wolff 2022-04-20 13:00:41 +02:00
parent 27bc68ab45
commit 173a263490
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CMakeLists.txt
View File

@ -111,7 +111,9 @@ if (BUILD_SHARED_LIBS)
${PUGIXML_BUILD_DEFINES} ${PUGIXML_BUILD_DEFINES}
${PUGIXML_PUBLIC_DEFINITIONS} ${PUGIXML_PUBLIC_DEFINITIONS}
PRIVATE PRIVATE
$<$<CXX_COMPILER_ID:MSVC>:PUGIXML_API=__declspec\(dllexport\)>) $<$<CXX_COMPILER_ID:MSVC>:PUGIXML_API=__declspec\(dllexport\)>
$<IF:$<CXX_COMPILER_ID:MSVC>,,PUGIXML_API=__attribute__\(\(visibility\("default"\)\)\)>
)
target_compile_options(pugixml-shared target_compile_options(pugixml-shared
PRIVATE PRIVATE
${msvc-rt-mtd-shared} ${msvc-rt-mtd-shared}