From e3f73112f32475649dc11530404c9616789af878 Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Sat, 3 Dec 2022 15:12:12 +0100 Subject: [PATCH] :rotating_light: suppress cppcoreguidelines-avoid-do-while --- .clang-tidy | 1 + include/nlohmann/detail/input/binary_reader.hpp | 2 +- include/nlohmann/detail/input/lexer.hpp | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 0739c7b33..ff84c58a0 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -7,6 +7,7 @@ Checks: '*, -cert-err58-cpp, -concurrency-mt-unsafe, -cppcoreguidelines-avoid-const-or-ref-data-members, + -cppcoreguidelines-avoid-do-while, -cppcoreguidelines-avoid-goto, -cppcoreguidelines-avoid-magic-numbers, -cppcoreguidelines-avoid-non-const-global-variables, diff --git a/include/nlohmann/detail/input/binary_reader.hpp b/include/nlohmann/detail/input/binary_reader.hpp index 058afd387..832c36ddf 100644 --- a/include/nlohmann/detail/input/binary_reader.hpp +++ b/include/nlohmann/detail/input/binary_reader.hpp @@ -2760,7 +2760,7 @@ class binary_reader */ char_int_type get_ignore_noop() { - do // NOLINT(cppcoreguidelines-avoid-do-while) + do { get(); } diff --git a/include/nlohmann/detail/input/lexer.hpp b/include/nlohmann/detail/input/lexer.hpp index 091035acf..72e995108 100644 --- a/include/nlohmann/detail/input/lexer.hpp +++ b/include/nlohmann/detail/input/lexer.hpp @@ -1499,7 +1499,7 @@ scan_number_done: void skip_whitespace() { - do // NOLINT(cppcoreguidelines-avoid-do-while) + do { get(); }