👌 addressed review comments
This commit is contained in:
parent
33379684b4
commit
d6ff059a90
@ -39,7 +39,7 @@ class diagnostics_t
|
|||||||
if (current->m_parent->m_value.array->operator[](i) == *current)
|
if (current->m_parent->m_value.array->operator[](i) == *current)
|
||||||
{
|
{
|
||||||
tokens.emplace_back(std::to_string(i));
|
tokens.emplace_back(std::to_string(i));
|
||||||
continue;
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
@ -52,7 +52,7 @@ class diagnostics_t
|
|||||||
if (element.second == *current)
|
if (element.second == *current)
|
||||||
{
|
{
|
||||||
tokens.emplace_back(element.first.c_str());
|
tokens.emplace_back(element.first.c_str());
|
||||||
continue;
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
@ -79,7 +79,7 @@ class diagnostics_t
|
|||||||
}
|
}
|
||||||
|
|
||||||
private:
|
private:
|
||||||
const BasicJsonType* m_j = static_cast<const BasicJsonType*>(nullptr);
|
const BasicJsonType* m_j = nullptr;
|
||||||
};
|
};
|
||||||
|
|
||||||
} // namespace detail
|
} // namespace detail
|
||||||
|
|||||||
@ -2537,7 +2537,7 @@ class diagnostics_t
|
|||||||
if (current->m_parent->m_value.array->operator[](i) == *current)
|
if (current->m_parent->m_value.array->operator[](i) == *current)
|
||||||
{
|
{
|
||||||
tokens.emplace_back(std::to_string(i));
|
tokens.emplace_back(std::to_string(i));
|
||||||
continue;
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
@ -2550,7 +2550,7 @@ class diagnostics_t
|
|||||||
if (element.second == *current)
|
if (element.second == *current)
|
||||||
{
|
{
|
||||||
tokens.emplace_back(element.first.c_str());
|
tokens.emplace_back(element.first.c_str());
|
||||||
continue;
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
@ -2577,7 +2577,7 @@ class diagnostics_t
|
|||||||
}
|
}
|
||||||
|
|
||||||
private:
|
private:
|
||||||
const BasicJsonType* m_j = static_cast<const BasicJsonType*>(nullptr);
|
const BasicJsonType* m_j = nullptr;
|
||||||
};
|
};
|
||||||
|
|
||||||
} // namespace detail
|
} // namespace detail
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user