From be6cdaa4b9c36e79895dd106d6f4189f0336205e Mon Sep 17 00:00:00 2001 From: Qianqian Fang Date: Wed, 23 Feb 2022 12:08:04 -0500 Subject: [PATCH] fix ci error, remove unwanted param comment --- include/nlohmann/detail/input/binary_reader.hpp | 2 +- include/nlohmann/detail/output/binary_writer.hpp | 1 - single_include/nlohmann/json.hpp | 3 +-- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/include/nlohmann/detail/input/binary_reader.hpp b/include/nlohmann/detail/input/binary_reader.hpp index 38c29a772..b1c82208a 100644 --- a/include/nlohmann/detail/input/binary_reader.hpp +++ b/include/nlohmann/detail/input/binary_reader.hpp @@ -2111,7 +2111,7 @@ class binary_reader { return false; } - result = ( (dim.size() > 0) ? 1 : 0 ); + result = ( (!dim.empty()) ? 1 : 0 ); for (auto i : dim) { result *= i; diff --git a/include/nlohmann/detail/output/binary_writer.hpp b/include/nlohmann/detail/output/binary_writer.hpp index 49369e023..2bfb4714f 100644 --- a/include/nlohmann/detail/output/binary_writer.hpp +++ b/include/nlohmann/detail/output/binary_writer.hpp @@ -37,7 +37,6 @@ class binary_writer @brief create a binary writer @param[in] adapter output adapter to write to - @param[in] is_bjdata_ a boolean, if true, output is BJData format, default is false */ explicit binary_writer(output_adapter_t adapter) : oa(std::move(adapter)) { diff --git a/single_include/nlohmann/json.hpp b/single_include/nlohmann/json.hpp index 44ed8dc89..a425adcb7 100644 --- a/single_include/nlohmann/json.hpp +++ b/single_include/nlohmann/json.hpp @@ -10487,7 +10487,7 @@ class binary_reader { return false; } - result = ( (dim.size() > 0) ? 1 : 0 ); + result = ( (!dim.empty()) ? 1 : 0 ); for (auto i : dim) { result *= i; @@ -13870,7 +13870,6 @@ class binary_writer @brief create a binary writer @param[in] adapter output adapter to write to - @param[in] is_bjdata_ a boolean, if true, output is BJData format, default is false */ explicit binary_writer(output_adapter_t adapter) : oa(std::move(adapter)) {