From b73c342c2ca08ffbcd2cf730b42e29f50410c875 Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Wed, 17 Aug 2022 22:34:08 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Florian Albrechtskirchinger --- .github/workflows/labeler.yml | 2 +- docs/mkdocs/docs/integration/migration_guide.md | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml index e970c6041..66cb7eb34 100644 --- a/.github/workflows/labeler.yml +++ b/.github/workflows/labeler.yml @@ -13,6 +13,6 @@ jobs: runs-on: ubuntu-latest steps: - - uses: falbrechtskirchinger/labeler@master + - uses: srvaroa/labeler@master env: GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}" diff --git a/docs/mkdocs/docs/integration/migration_guide.md b/docs/mkdocs/docs/integration/migration_guide.md index 6029981c6..a7eaa41f0 100644 --- a/docs/mkdocs/docs/integration/migration_guide.md +++ b/docs/mkdocs/docs/integration/migration_guide.md @@ -1,11 +1,11 @@ # Migration Guide -This page collects some guidelines how to future-proof your code for future versions of this library. +This page collects some guidelines on how to future-proof your code for future versions of this library. ## Replace deprecated functions -The following functions have been deprecated in earlier versions and will be removed in the next major version (i.e., -4.0.0). All deprecations are annotated with +The following functions have been deprecated and will be removed in the next major version (i.e., 4.0.0). All +deprecations are annotated with [`HEDLEY_DEPRECATED_FOR`](https://nemequ.github.io/hedley/api-reference.html#HEDLEY_DEPRECATED_FOR) to report which function to use instead. @@ -148,12 +148,12 @@ function to use instead. - The legacy comparison behavior for discarded values is deprecated since 3.11.0. It is already disabled by default and can still be enabled by defining - [`JSON_USE_LEGACY_DISCARDED_VALUE_COMPARISON`](../api/macros/json_use_legacy_discarded_value_comparison.md). + [`JSON_USE_LEGACY_DISCARDED_VALUE_COMPARISON`](../api/macros/json_use_legacy_discarded_value_comparison.md) to `1`. === "Deprecated" ```cpp - #define JSON_USE_LEGACY_DISCARDED_VALUE_COMPARISON + #define JSON_USE_LEGACY_DISCARDED_VALUE_COMPARISON 1 #include ```