External/json
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

✅ add regression test #2824

Browse Source
This commit is contained in:
Niels Lohmann 2021-07-30 14:41:06 +02:00
parent 1c030cccf1
commit 2c030bac2c
No known key found for this signature in database
GPG Key ID: 7F3CEA63AE251B69
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
test/src/unit-regression2.cpp
View File

@ -166,16 +166,16 @@ class sax_no_exception : public nlohmann::detail::json_sax_dom_parser<json>
public: public:
explicit sax_no_exception(json& j) : nlohmann::detail::json_sax_dom_parser<json>(j, false) {} explicit sax_no_exception(json& j) : nlohmann::detail::json_sax_dom_parser<json>(j, false) {}
static bool parse_error(std::size_t position, const std::string& last_token, const json::exception& ex) static bool parse_error(std::size_t /*position*/, const std::string& /*last_token*/, const json::exception& ex)
{ {
error_string = ex.what(); error_string = new std::string(ex.what());
return false; return false;
} }
static std::string error_string; static std::string* error_string;
}; };
std::string sax_no_exception::error_string = ""; std::string* sax_no_exception::error_string = nullptr;
TEST_CASE("regression tests 2") TEST_CASE("regression tests 2")
@ -648,7 +648,8 @@ TEST_CASE("regression tests 2")
sax_no_exception sax(j); sax_no_exception sax(j);
CHECK (!json::sax_parse("xyz", &sax)); CHECK (!json::sax_parse("xyz", &sax));
CHECK(sax_no_exception::error_string == "[json.exception.parse_error.101] parse error at line 1, column 1: syntax error while parsing value - invalid literal; last read: 'x'"); CHECK(*sax_no_exception::error_string == "[json.exception.parse_error.101] parse error at line 1, column 1: syntax error while parsing value - invalid literal; last read: 'x'");
delete sax_no_exception::error_string;
} }
SECTION("issue #2825 - Properly constrain the basic_json conversion operator") SECTION("issue #2825 - Properly constrain the basic_json conversion operator")