👷 add CI step for coverage

.github/workflows/ubuntu.yml

@@ -130,7 +130,7 @@ jobs:
       - name: build
         run: cmake --build build --target ci_test_coverage
       - name: copy
-        run: cp -r html /workdir ; cp -r json.info /workdir
+        run: cp -r build/build_coverage/html /workdir ; cp -r build/build_coverage/json.info /workdir
       - name: archive coverage report
         uses: actions/upload-artifact@v2
         with:

test/src/unit-constructor1.cpp

@@ -1119,7 +1119,7 @@ TEST_CASE("constructors")
                 {
                     // This should break through any short string optimization in std::string
                     std::string source(1024, '!');
-                    const char* source_addr = source.data();
+                    const char* source_addr = source.data(); // NOLINT(clang-analyzer-cplusplus.InnerPointer)
                     json j = {std::move(source)};
                     CHECK(j[0].get_ref<std::string const&>().data() == source_addr);
                 }
@@ -1128,7 +1128,7 @@ TEST_CASE("constructors")
                 {
                     // This should break through any short string optimization in std::string
                     std::string source(1024, '!');
-                    const char* source_addr = source.data();
+                    const char* source_addr = source.data(); // NOLINT(clang-analyzer-cplusplus.InnerPointer)
                     json j = {{"key", std::move(source)}};
                     CHECK(j["key"].get_ref<std::string const&>().data() == source_addr);
                 }
@@ -1137,7 +1137,7 @@ TEST_CASE("constructors")
                 {
                     // This should break through any short string optimization in std::string
                     std::string source(1024, '!');
-                    const char* source_addr = source.data();
+                    const char* source_addr = source.data(); // NOLINT(clang-analyzer-cplusplus.InnerPointer)
                     json j = {{std::move(source), 42}};
                     CHECK(j.get_ref<json::object_t&>().begin()->first.data() == source_addr);
                 }
@@ -1148,7 +1148,7 @@ TEST_CASE("constructors")
                 SECTION("constructor with implicit types (array)")
                 {
                     json::array_t source = {1, 2, 3};
-                    const json* source_addr = source.data();
+                    const json* source_addr = source.data(); // NOLINT(clang-analyzer-cplusplus.InnerPointer)
                     json j {std::move(source)};
                     CHECK(j[0].get_ref<json::array_t const&>().data() == source_addr);
                 }
@@ -1156,7 +1156,7 @@ TEST_CASE("constructors")
                 SECTION("constructor with implicit types (object)")
                 {
                     json::array_t source = {1, 2, 3};
-                    const json* source_addr = source.data();
+                    const json* source_addr = source.data(); // NOLINT(clang-analyzer-cplusplus.InnerPointer)
                     json j {{"key", std::move(source)}};
                     CHECK(j["key"].get_ref<json::array_t const&>().data() == source_addr);
                 }
@@ -1164,7 +1164,7 @@ TEST_CASE("constructors")
                 SECTION("assignment with implicit types (array)")
                 {
                     json::array_t source = {1, 2, 3};
-                    const json* source_addr = source.data();
+                    const json* source_addr = source.data(); // NOLINT(clang-analyzer-cplusplus.InnerPointer)
                     json j = {std::move(source)};
                     CHECK(j[0].get_ref<json::array_t const&>().data() == source_addr);
                 }
@@ -1172,7 +1172,7 @@ TEST_CASE("constructors")
                 SECTION("assignment with implicit types (object)")
                 {
                     json::array_t source = {1, 2, 3};
-                    const json* source_addr = source.data();
+                    const json* source_addr = source.data(); // NOLINT(clang-analyzer-cplusplus.InnerPointer)
                     json j = {{"key", std::move(source)}};
                     CHECK(j["key"].get_ref<json::array_t const&>().data() == source_addr);
                 }

test/src/unit-regression1.cpp

@@ -94,7 +94,7 @@ template<typename T>
 struct foo_serializer < T, typename std::enable_if < !std::is_same<foo, T>::value >::type >
 {
     template <typename BasicJsonType>
-    static void to_json(BasicJsonType& j, const T& value) noexcept
+    static void to_json(BasicJsonType& j, const T& value) noexcept // NOLINT(bugprone-exception-escape)
     {
         ::nlohmann::to_json(j, value);
     }

test/src/unit-udt.cpp

@@ -407,7 +407,7 @@ TEST_CASE("adl_serializer specialization" * doctest::test_suite("udt"))
             json j = optPerson;
             CHECK(j.is_null());
 
-            optPerson.reset(new udt::person{{42}, {"John Doe"}, udt::country::russia}); // NOLINT(cppcoreguidelines-owning-memory)
+            optPerson.reset(new udt::person{{42}, {"John Doe"}, udt::country::russia}); // NOLINT(cppcoreguidelines-owning-memory,modernize-make-shared)
             j = optPerson;
             CHECK_FALSE(j.is_null());
 

test/thirdparty/fifo_map/fifo_map.hpp

@@ -99,7 +99,7 @@ template <
     class T,
     class Compare = fifo_map_compare<Key>,
     class Allocator = std::allocator<std::pair<const Key, T>>
-    > class fifo_map
+    > class fifo_map // NOLINT(cppcoreguidelines-special-member-functions,hicpp-special-member-functions,-warnings-as-errors)
 {
   public:
     using key_type = Key;
@@ -514,10 +514,10 @@ template <
     internal_map_type m_map;
 };
 
-}
+} // namespace nlohmann
 
 // specialization of std::swap
-namespace std
+namespace std // NOLINT(cert-dcl58-cpp,-warnings-as-errors)
 {
 template <class Key, class T, class Compare, class Allocator>
 inline void swap(nlohmann::fifo_map<Key, T, Compare, Allocator>& m1,
@@ -525,6 +525,6 @@ inline void swap(nlohmann::fifo_map<Key, T, Compare, Allocator>& m1,
 {
     m1.swap(m2);
 }
-}
+} // namespace std
 
 #endif