External/json
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix warning: enumeration value not handled in switch

Browse Source 
In this case the switch is useless since the other cases
are already excluded by the initial asserts.
Removing the switch altogether seems the best way forward.
This commit is contained in:
Cristian Maglie 2017-04-15 13:18:41 +02:00
parent 523cc21514
commit 14dcd918a8
2 changed files with 32 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/json.hpp
View File

@ -12093,37 +12093,27 @@ basic_json_parser_74:
strtonum num_converter(reinterpret_cast<const char*>(m_start), strtonum num_converter(reinterpret_cast<const char*>(m_start),
reinterpret_cast<const char*>(m_cursor)); reinterpret_cast<const char*>(m_cursor));
switch (token) if (token == lexer::token_type::value_unsigned)
{ {
case lexer::token_type::value_unsigned: number_unsigned_t val;
if (num_converter.to(val))
{ {
number_unsigned_t val; // parsing successful
if (num_converter.to(val)) result.m_type = value_t::number_unsigned;
{ result.m_value = val;
// parsing successful return true;
result.m_type = value_t::number_unsigned;
result.m_value = val;
return true;
}
break;
} }
}
case lexer::token_type::value_integer: if (token == lexer::token_type::value_integer)
{
number_integer_t val;
if (num_converter.to(val))
{ {
number_integer_t val; // parsing successful
if (num_converter.to(val)) result.m_type = value_t::number_integer;
{ result.m_value = val;
// parsing successful return true;
result.m_type = value_t::number_integer;
result.m_value = val;
return true;
}
break;
}
default:
{
break;
} }
} }

42
src/json.hpp.re2c
View File

@ -11126,37 +11126,27 @@ class basic_json
strtonum num_converter(reinterpret_cast<const char*>(m_start), strtonum num_converter(reinterpret_cast<const char*>(m_start),
reinterpret_cast<const char*>(m_cursor)); reinterpret_cast<const char*>(m_cursor));
switch (token) if (token == lexer::token_type::value_unsigned)
{ {
case lexer::token_type::value_unsigned: number_unsigned_t val;
if (num_converter.to(val))
{ {
number_unsigned_t val; // parsing successful
if (num_converter.to(val)) result.m_type = value_t::number_unsigned;
{ result.m_value = val;
// parsing successful return true;
result.m_type = value_t::number_unsigned;
result.m_value = val;
return true;
}
break;
} }
}
case lexer::token_type::value_integer: if (token == lexer::token_type::value_integer)
{
number_integer_t val;
if (num_converter.to(val))
{ {
number_integer_t val; // parsing successful
if (num_converter.to(val)) result.m_type = value_t::number_integer;
{ result.m_value = val;
// parsing successful return true;
result.m_type = value_t::number_integer;
result.m_value = val;
return true;
}
break;
}
default:
{
break;
} }
} }