External/json
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

⏪ remove std::forward in loops

Browse Source
This commit is contained in:
Niels Lohmann 2023-06-07 20:13:43 +02:00
parent 3b058ac9f6
commit 085a7fb76f
No known key found for this signature in database
GPG Key ID: 7F3CEA63AE251B69
2 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
include/nlohmann/ordered_map.hpp
View File

@ -122,7 +122,7 @@ template <class Key, class T, class IgnoredLess = std::less<Key>,
{
for (auto it = this->begin(); it != this->end(); ++it)
{
if (m_compare(it->first, std::forward<KeyType>(key)))
if (m_compare(it->first, key)) // NOLINT(cppcoreguidelines-missing-std-forward)
{
return it->second;
}
@ -150,7 +150,7 @@ template <class Key, class T, class IgnoredLess = std::less<Key>,
{
for (auto it = this->begin(); it != this->end(); ++it)
{
if (m_compare(it->first, std::forward<KeyType>(key)))
if (m_compare(it->first, key)) // NOLINT(cppcoreguidelines-missing-std-forward)
{
return it->second;
}
@ -184,10 +184,10 @@ template <class Key, class T, class IgnoredLess = std::less<Key>,
{
for (auto it = this->begin(); it != this->end(); ++it)
{
if (m_compare(it->first, std::forward<KeyType>(key)))
{
// Since we cannot move const Keys, re-construct them in place
for (auto next = it; ++next != this->end(); ++it)
if (m_compare(it->first, key) // NOLINT(cppcoreguidelines-missing-std-forward)
{
// Since we cannot move const Keys, re-construct them in place
for (auto next = it; ++next != this->end(); ++it)
{
it->~value_type(); // Destroy but keep allocation
new (&*it) value_type{std::move(*next)};
@ -275,7 +275,7 @@ template <class Key, class T, class IgnoredLess = std::less<Key>,
{
for (auto it = this->begin(); it != this->end(); ++it)
{
if (m_compare(it->first, std::forward<KeyType>(key)))
if (m_compare(it->first, key))// NOLINT(cppcoreguidelines-missing-std-forward)
{
return 1;
}
@ -301,7 +301,7 @@ template <class Key, class T, class IgnoredLess = std::less<Key>,
{
for (auto it = this->begin(); it != this->end(); ++it)
{
if (m_compare(it->first, std::forward<KeyType>(key)))
if (m_compare(it->first, key)) // NOLINT(cppcoreguidelines-missing-std-forward)
{
return it;
}

16
single_include/nlohmann/json.hpp
View File

@ -19040,7 +19040,7 @@ template <class Key, class T, class IgnoredLess = std::less<Key>,
{
for (auto it = this->begin(); it != this->end(); ++it)
{
if (m_compare(it->first, std::forward<KeyType>(key)))
if (m_compare(it->first, key)) // NOLINT(cppcoreguidelines-missing-std-forward)
{
return it->second;
}
@ -19068,7 +19068,7 @@ template <class Key, class T, class IgnoredLess = std::less<Key>,
{
for (auto it = this->begin(); it != this->end(); ++it)
{
if (m_compare(it->first, std::forward<KeyType>(key)))
if (m_compare(it->first, key)) // NOLINT(cppcoreguidelines-missing-std-forward)
{
return it->second;
}
@ -19102,10 +19102,10 @@ template <class Key, class T, class IgnoredLess = std::less<Key>,
{
for (auto it = this->begin(); it != this->end(); ++it)
{
if (m_compare(it->first, std::forward<KeyType>(key)))
{
// Since we cannot move const Keys, re-construct them in place
for (auto next = it; ++next != this->end(); ++it)
if (m_compare(it->first, key) // NOLINT(cppcoreguidelines-missing-std-forward)
{
// Since we cannot move const Keys, re-construct them in place
for (auto next = it; ++next != this->end(); ++it)
{
it->~value_type(); // Destroy but keep allocation
new (&*it) value_type{std::move(*next)};
@ -19193,7 +19193,7 @@ template <class Key, class T, class IgnoredLess = std::less<Key>,
{
for (auto it = this->begin(); it != this->end(); ++it)
{
if (m_compare(it->first, std::forward<KeyType>(key)))
if (m_compare(it->first, key))// NOLINT(cppcoreguidelines-missing-std-forward)
{
return 1;
}
@ -19219,7 +19219,7 @@ template <class Key, class T, class IgnoredLess = std::less<Key>,
{
for (auto it = this->begin(); it != this->end(); ++it)
{
if (m_compare(it->first, std::forward<KeyType>(key)))
if (m_compare(it->first, key)) // NOLINT(cppcoreguidelines-missing-std-forward)
{
return it;
}