External/googletest
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
4,157 Commits 1 Branch 22 Tags 13 MiB
e49c6b946a
Commit Graph

591 Commits

Author SHA1 Message Date
Copybara-Service
e49c6b946a Merge pull request #4180 from sergio-nsk:patch-3 
PiperOrigin-RevId: 517200256
Change-Id: I2ad5d4644f9e2095909ef646a7207c42a38082cf
 2023-03-16 12:46:37 -07:00
Lawrence Wolf-Sonkin
038e392ebd [gtest] Drop custom-rolled heterogeneous comparator functors in favor of C++ standard ones 
* Standard heterogeneous comparator functors such as `std::equal_to<>` and `std::less<>` [have been available since C++14](https://en.cppreference.com/w/cpp/utility/functional/less_void)
* Now that [C++14 is the minimum supported version of C++ in Googletest](https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md), let's delete these duplications of the standard library

PiperOrigin-RevId: 515743068
Change-Id: I1563a2f94039c3a6688429298555545a922f6d7e
 2023-03-10 14:43:13 -08:00
Sergey
2d3b36d40a Environment variables are accessible in UWP/WinRT apps 
Environment variables, for example `GTEST_FILTER`, `GTEST_OUTPUT` can be set
before getting WinRT app run. GoogleTest can read environment variables and use
them. It's easier than setting and passing command line parameters to WinRT app.
 2023-03-10 09:30:49 -07:00
Abseil Team
cf4f4400db Suppress std::string DLL interface warning introduced in commit f063cd25c9 
Fixes #4171

PiperOrigin-RevId: 514777144
Change-Id: I6f4b309c407684522fc1bc94dcc980ea1fe09cd9
 2023-03-07 10:40:39 -08:00
Tom Hughes
d92a270d2d Fix compilation with -Wundef. 
Fixes #3267

PiperOrigin-RevId: 513946600
Change-Id: I0dd1daa04aeb735a238c4c0af6676565d64cbc21
 2023-03-06 07:19:04 -08:00
Tom Hughes
2ddba26691 Always specify definitions for internal macros 
These macros should only be used within googletest, so changing them will not
affect external users.

This allows compiling with -Wundef (#3267).

PiperOrigin-RevId: 513946162
Change-Id: I2f2b7df9123adeba4147593b2b55fde349ccce4f
 2023-03-06 07:18:52 -08:00
Tom Hughes
16feffa8fa Replace "#if GTEST_HAS_ABSL" with "#ifdef GTEST_HAS_ABSL" 
This allows compilation with "-Wundef" (#3267).

PiperOrigin-RevId: 513945230
Change-Id: I45ef19c7ff3d20e97216bd031d406a03365471da
 2023-03-06 07:16:32 -08:00
Tom Hughes
dc10c3b5e5 Use "#ifdef" with public macros 
This allows compilation with "-Wundef" (#3267).

PiperOrigin-RevId: 513944726
Change-Id: I1a3854bb2333d5dec6c0ff91ee1eddd9a766ab91
 2023-03-06 07:15:44 -08:00
Tom Hughes
7b1ced0682 Only define GTEST_IS_THREADSAFE to 1, not 0 
According to the comments, "Feature-indicating macros",
such as GTEST_IS_THREADSAFE should be defined to 1 when supported
and otherwise undefined (never 0).

PiperOrigin-RevId: 513944266
Change-Id: I0f5c8bed107a5f20e957ec7c70339540ca2fe831
 2023-03-06 07:15:32 -08:00
Tom Hughes
a08c03c5f5 Always specify definitions for internal macros 
These macros should only be used within googletest, so changing them will not
affect external users.

This allows compiling with -Wundef (#3267).

PiperOrigin-RevId: 513943800
Change-Id: I697b1005c29b0d5af06f583f202d86db48b567b9
 2023-03-06 07:15:17 -08:00
Tom Hughes
23142843f7 Use "#ifdef GTEST_OS_..." instead of "#if GTEST_OS_..." 
This is compatible with compiling with "-Wundef" (#3267).

PiperOrigin-RevId: 513943378
Change-Id: I47cf5fabbb77be061c4483a0adc54511af6b191c
 2023-03-06 07:14:21 -08:00
Phoebe Liang
6882aa0987 Reorder printers list. 
PiperOrigin-RevId: 512708763
Change-Id: I1f24f2e1d17359aee5aa4cdf614c9357872ca03b
 2023-02-27 13:03:15 -08:00
Abseil Team
3d787f5a0d Add const qualifier to gtest_sentinel which doesn't change. 
PiperOrigin-RevId: 512094429
Change-Id: I29b116da65bc7471c43021d1650d90f7b2a685c2
 2023-02-24 09:50:32 -08:00
Dino Radakovic
39a26e12d6 Avoid redundant declaration of static constexpr members in c++17 
Keep declarations in c++ < 17 using new macro, GTEST_INTERNAL_NEED_REDUNDANT_CONSTEXPR_DECL.

Fixes #4148.

PiperOrigin-RevId: 511510401
Change-Id: I76c3f2fccf07a0978adcbe5f8f0203b9d0c33872
 2023-02-22 09:02:55 -08:00
Tom Hughes
750d67d809 Remove int64_t cast in RecordProperty 
Historically, calls to RecordProperty with values that are convertible to
int64_t have been casted to int64_t. The result was that types like float or
double would be truncated when printed (e.g., 4.75 -> 4). This change removes
the cast so that the types are printed in a more appropriate manner.

PiperOrigin-RevId: 511238685
Change-Id: I80de5db14462da2a3e1f476086025ae514383a17
 2023-02-21 10:25:39 -08:00
Abseil Team
f063cd25c9 Remove strdup usage 
PiperOrigin-RevId: 509947007
Change-Id: I31e1274afa889776829c877c40c9af589298dcf2
 2023-02-15 15:22:10 -08:00
Abseil Team
b80a07ffe6 Avoid reliance on <any> header without RTTI on MSVC 
Fixes: #4144
PiperOrigin-RevId: 509322023
Change-Id: I52bdf6c25ff433327e174d3f9583b3d50b872d58
 2023-02-13 13:46:03 -08:00
Tom Hughes
deaf5615f1 Fix -Wsign-conversion warnings 
googletest/test/gtest_xml_outfile2_test_.cc:48:39:
warning: implicit conversion turns floating-point number into integer:
'float' to 'int64_t' (aka 'long') [-Wfloat-conversion]
  RecordProperty("TestFloatProperty", float_prop);
  ~~~~~~~~~~~~~~                      ^~~~~~~~~~

googletest/test/gtest_xml_outfile2_test_.cc:51:40:
warning: implicit conversion turns floating-point number into integer:
'double' to 'int64_t' (aka 'long') [-Wfloat-conversion]
  RecordProperty("TestDoubleProperty", double_prop);
  ~~~~~~~~~~~~~~                       ^~~~~~~~~~~

googletest/test/gtest_xml_outfile2_test_.cc:57:39:
warning: implicit conversion changes signedness:
'size_t' (aka 'unsigned long') to 'int64_t' (aka 'long') [-Wsign-conversion]
  RecordProperty("TestSizetProperty", size_t_prop);
  ~~~~~~~~~~~~~~                      ^~~~~~~~~~~
PiperOrigin-RevId: 506644143
Change-Id: I9c2cd5f52daebe25e73bb97f696687797ed2cabf
 2023-02-02 09:31:44 -08:00
Tom Hughes
4fb7039fda Use GTEST_DISABLE_MSC_WARNINGS macros to disable warnings 
Prior to this change we had a mixture of pragmas and
GTEST_DISABLE_MSC_WARNINGS; this change consolidates all instances
to use the macros.

PiperOrigin-RevId: 505786926
Change-Id: I2be8f6304387393995081af42ed32c2ad1bba5a7
 2023-01-30 13:45:46 -08:00
Tom Hughes
2491710524 Fix formatting of C++ files 
PiperOrigin-RevId: 504325204
Change-Id: Iaa1d6d0ab1dccaaeef26f9cb109d530835499240
 2023-01-24 11:10:09 -08:00
Derek Mauro
544c96ed5b Remove FloatingPoint::Max() in favor of std::numeric_limits::max() 
In #4113 a user says Max clashes with a macro. Since it is only used in
a test, use std::numeric_limits::max() instead.

Note that in headers, the macro issue can be mitigated with
parenthesis like this: `(std::numeric_limits<T>::max)()`

PiperOrigin-RevId: 504284906
Change-Id: Ibf430caec1a6afdf6b303534fec6a4fd00a6373f
 2023-01-24 08:41:35 -08:00
Tom Hughes
5cd81a7848 Fix -Wimplicit-int-float-conversion warning 
We're intentionally losing precision in this case, so add a cast.

googletest/googletest/include/gtest/gtest-printers.h:532:9: error:
implicit conversion from 'int32_t' (aka 'int') to 'float' may lose precision
[-Werror,-Wimplicit-int-float-conversion]
    if (static_cast<int32_t>(val * mulfor6 + 0.5) / mulfor6 == val) return 6;
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~

googletest/googletest/include/gtest/gtest-printers.h:544:9: error:
implicit conversion from 'int32_t' (aka 'int') to 'float' may lose precision
[-Werror,-Wimplicit-int-float-conversion]
    if (static_cast<int32_t>(val / divfor6 + 0.5) * divfor6 == val) return 6;
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~

PiperOrigin-RevId: 502646042
Change-Id: I05989ee42675b531a9907616c9582a5a7c77bed6
 2023-01-17 11:44:46 -08:00
Derek Mauro
b5401fef68 Add an explicit #error that C++ versions less than C++14 are not supported 
PiperOrigin-RevId: 501568410
Change-Id: I0f78cd96dc9204c8ec97a1cdd09a9d63a613cc5b
 2023-01-12 08:10:36 -08:00
Tom Hughes
e5e46b09a1 IWYU: Add missing std includes 
PiperOrigin-RevId: 499893032
Change-Id: I33304802b7c82ae2d008f3ee89df38866e5f57ba
 2023-01-05 08:44:01 -08:00
Tom Hughes
3a99ab6d83 Fix _MSC_VER check 
Use "#if defined(_MSC_VER)" instead of "#if _MSC_VER" to be consistent with other usages in the file and to work with the "-Wundef" warning.

PiperOrigin-RevId: 499471290
Change-Id: I34a9442eecf266afd74d4332cab7d39766df4ed9
 2023-01-04 06:40:48 -08:00
Abseil Team
b0846aaf37 Introduces a new porting flag (GTEST_HAS_FILE_SYSTEM) to indicate whether a platform supports filesystem operations. 
PiperOrigin-RevId: 494751986
Change-Id: I07f73bdf478a73934b8f1a69c1ab4abda1b231ae
 2022-12-12 09:34:12 -08:00
Abseil Team
9c332145b7 When printing floating-point numbers, print full precision by default. 
To make debug output readable, we still use the faster 6-digit precision
sometimes, but only if it will round-trip.

This way, when a test fails due to a very small difference in floating-point
numbers, users will have enough digits to see the difference.

PiperOrigin-RevId: 488958311
Change-Id: Ibcac43f48a97006d89217530c69386cc4fa2735c
 2022-11-16 09:18:37 -08:00
Abseil Team
4408a0288b Remove incorrect usage of GTEST_ATTRIBUTE_UNUSED_ on classes. 
Fixes: #4054
PiperOrigin-RevId: 488721587
Change-Id: I8742d8475376635c83edcf524796a6107042e89b
 2022-11-15 12:01:35 -08:00
Abseil Team
912db74253 Defined a testing::SrcDir() function that returns the name of a directory 
where ancillary data files can be found.

PiperOrigin-RevId: 487896836
Change-Id: Ie6b1ba734e900fa33872b63090879ee6efe33411
 2022-11-11 12:59:10 -08:00
Copybara-Service
44c03643cf Merge pull request #4039 from zloylos:fix-return-fail-at-4038 
PiperOrigin-RevId: 487516335
Change-Id: Ib475750586fc7e6ab01729f65253e3a86916b994
 2022-11-10 06:13:31 -08:00
Abseil Team
386c7665f5 RecordProperty serializes ints and 64-bit ints, including size_ts 
PiperOrigin-RevId: 486685761
Change-Id: I164d2646e65670d341dbf437ee571953c456677a
 2022-11-07 09:36:56 -08:00
Abseil Team
a4f02ef389 Fix typo in documentation of ConvertGenerator() 
PiperOrigin-RevId: 486316328
Change-Id: I91d5d5ba1aaf4a4ab14019c8963e7fe181722f95
 2022-11-05 01:07:38 -07:00
Abseil Team
f372c76026 Adds Win32 UNC path support to FilePath::IsAbsolutePath() and FilePath::IsRootDirectory() in GoogleTest 
Fixes: #3025
PiperOrigin-RevId: 481932601
Change-Id: I90fcb5b3d189aea79a0fd18735bad038b3511270
 2022-10-18 08:52:33 -07:00
Derek Mauro
26d3ab5442 Fix detection of the no_sanitize("hwaddress") attribute 
PiperOrigin-RevId: 481765573
Change-Id: I1ba829c3cbf364a51d3ba383ee3b474c0e109578
 2022-10-17 16:15:59 -07:00
Denis Hananein
6f149520a1 Add return for GTEST_FAIL_AT 2022-10-16 01:57:22 +02:00
Derek Mauro
a9b2f0495c Use attribute testing to simplify portable attribute macros 
Fixes #4025

PiperOrigin-RevId: 481186097
Change-Id: Id7d09e4626e5ccf564e8cfaa65581c1cd827918d
 2022-10-14 11:00:40 -07:00
Abseil Team
137b6e2770 Terse printing of std::reference_wrapper hides pointer 
This matches the intention and documentation of terse printing which generally avoids printing the pointer.

PiperOrigin-RevId: 481178950
Change-Id: I27039dac1870934d2d5b212e2cc7e97ab82c5b34
 2022-10-14 10:32:49 -07:00
Copybara-Service
8c4dc11539 Merge pull request #3967 from BMBurstein:custom_type_combine 
PiperOrigin-RevId: 478775323
Change-Id: I92231bb8edd8e01b9b7cbe445c43dcf84f458521
 2022-10-04 07:06:58 -07:00
Abseil Team
93f08be653 Uses a simpler mechanism to disable the copying of GoogleTest test suites, to move code out of the TEST_P macro. 
PiperOrigin-RevId: 478031678
Change-Id: I45f0ce17a4add526c86b8212d836d98d63b3a193
 2022-09-30 10:55:15 -07:00
Abseil Team
d1a0039b97 Rollback: Moves boilerplate disabling copy constructor/assignment from GoogleTest's TEST_P macro into a header file to avoid triggering warnings in user code. 
PiperOrigin-RevId: 477566426
Change-Id: Ia417e295d839f43be6e61a5699457866108f2a01
 2022-09-28 15:24:50 -07:00
Abseil Team
19387c9dd5 Rollback: Uses a simpler mechanism to disable the copying of GoogleTest test suites. 
PiperOrigin-RevId: 477560280
Change-Id: I1c1f5a1d6645859ec38cb1a75cd267816d2aff35
 2022-09-28 14:59:04 -07:00
Abseil Team
c43b916a96 Uses a simpler mechanism to disable the copying of GoogleTest test suites. 
PiperOrigin-RevId: 477549427
Change-Id: I6421ca09f0f1296cebdc3e54565049f1542dfa8a
 2022-09-28 14:14:58 -07:00
Abseil Team
4924e0610a Moves boilerplate disabling copy constructor/assignment from GoogleTest's TEST_P macro into a header file to avoid triggering warnings in user code. 
Fixes #4015

PiperOrigin-RevId: 477513399
Change-Id: Ia21928ee12e85946b4c8db86835d225cb257eecc
 2022-09-28 11:55:57 -07:00
Baruch
24683e2d6a
Merge branch 'google:main' into custom_type_combine 2022-09-28 11:32:21 +03:00
Copybara-Service
e23cdb78e9 Merge pull request #4016 from Maratyszcza:qurt 
PiperOrigin-RevId: 477265396
Change-Id: I781dae4ef2c5b6c771d960f1ec5a3c5cff0e97ad
 2022-09-27 13:49:56 -07:00
Marat Dukhan
7a3abfec0a Port GoogleTest to QuRT (Hexagon RTOS) 2022-09-26 14:49:00 -07:00
Baruch
dd969ed5fe
Merge branch 'google:main' into custom_type_combine 2022-08-25 10:55:49 +03:00
Dino Radakovic
5b909beeec Explicitly instantiate matchee std::string in MatchesRegex 
If this ever turns out to be a performance issue, we could use std::conditional and std::is_same to avoid copying std::strings.

Fixes #3949

PiperOrigin-RevId: 465353572
Change-Id: If2d691bccb626c692c87e006df5afe88a4ed1542
 2022-08-04 10:53:57 -07:00
Baruch Burstein
3280a930bf Custom type with Combine(). Fix for #3781 2022-07-31 22:50:04 +03:00
Yuriy Chernyshov
aa2e91fd69
Continuation for #3183 
Some of the #ifdefs were missed in original PR.
Should be fixed now.
 2022-07-21 14:25:43 +03:00