5 Commits

Author	SHA1	Message	Date
Victor Costan	b3a1759eac	Fix std::iscntrl use in gtest-printers.cc ... ContainsUnprintableControlCodes() in gtest-printers.cc passes a char argument to std::iscntrl. Although its argument is an int, std::iscntrl produces undefined behavior if its argument is not representable as an unsigned char. The standard library on Windows asserts that the argument is an unsigned char, resulting in an assertion crash on debug builds.	2018-02-12 13:02:07 -08:00
Troy Holsapple	c8510504dd	Fixed typos	2018-02-07 22:06:00 -08:00
Gennadiy Civil	e29805aa5d	upstream cl 182543808	2018-01-24 13:04:36 -05:00
Brian Silverman	4d26df729c	Speed up printing of characters which need hex escaping ... This change speeds up the runtime of a value-parameterized test I have which has lots of values with large strings full of unprintable characters by 2x. I profiled it and traced most of the slowness during googletest startup down to the way String::FormatHexInt was creating and destroyed a stringstream for each character in the string for each value.	2017-08-28 16:00:48 -04:00
Billy Donahue	1f87a0970d	Move everything in googletest into googletest/googletest	2015-08-25 16:18:00 -04:00