Commit Graph

4291 Commits

Author SHA1 Message Date
Juan Ramos
4fed5f2850 cmake: Raise min to 3.6
From the CMake 3.27 release notes:
Compatibility with versions of CMake older than 3.5 is now
deprecated and will be removed from a future version. Calls to
cmake_minimum_required() or cmake_policy() that set the policy
version to an older value now issue a deprecation diagnostic.

This PR also removes manually setting policy CMP0048. This is
redundant since the CMake min is already 3.X
2023-06-19 11:21:44 -06:00
Ryan Schmidt
124bc587f0
Change C++11 requirement to C++14
Version 1.13.x and later require C++14.

Also fix missing closing backtick.
2023-06-19 06:18:12 -05:00
Copybara-Service
9b12f749fa Merge pull request #4267 from niranjan-nilakantan:niranjan-nilakantan/issue4266
PiperOrigin-RevId: 540901148
Change-Id: Ifd4c4a6d37e9bf7ff63470be401f94d2bb530c22
2023-06-16 09:18:27 -07:00
Kasra Hashemi
148b327ffa
Update README.md
Fixed punctuation issues
2023-06-16 13:59:16 +03:30
Abseil Team
18fa6a4db3 Allow clients to un-suppress output from gUnit EXPECT_EXIT tests.
This is useful for running individual tests in a separate process, which is
useful for testing e.g. flag changes which have a process-global effect.

PiperOrigin-RevId: 540580573
Change-Id: I18a5d24d79425a9d595be3369efc44e2f655f6f8
2023-06-15 07:52:45 -07:00
Dino Radakovic
4c7aee827e Skip entire test suite with GTEST_SKIP() in SetUpTestSuite
Fixes #4273

PiperOrigin-RevId: 540254167
Change-Id: I2555740d10284223539035bf73f88554fcf73f8a
2023-06-14 06:41:11 -07:00
Copybara-Service
e9078161e6 Merge pull request #4188 from Mizzrym1:component
PiperOrigin-RevId: 539684886
Change-Id: Ie7f4175ad413fdb82d265374a4aca9fad23571f5
2023-06-12 09:58:37 -07:00
Abseil Team
65cfeca1a1 internal g3doc documentation change.
PiperOrigin-RevId: 539134110
Change-Id: I28041f77e18bc67aa0ffabdc7205e350deed22c8
2023-06-09 11:29:42 -07:00
Copybara-Service
334704df26 Merge pull request #4269 from elupus:patch-3
PiperOrigin-RevId: 538253216
Change-Id: Ib4bc90974f92939f884d6b5927f8bf37aac4d2c7
2023-06-06 12:04:10 -07:00
Copybara-Service
23f642ab23 Merge pull request #4260 from pratyush3757:readme_table_fix
PiperOrigin-RevId: 537887202
Change-Id: I4a52ec0da24f043eba0aa1a9d7945066c799ce8a
2023-06-05 08:47:33 -07:00
Joakim Plate
001f281926
Check for file system for current directory
Check for current directory instead of death test to get original directory.

A port may support filesystems but not death tests.
2023-06-02 12:17:43 +02:00
Pro3757
5ca3ab8331 change table to unordered list 2023-06-02 01:09:32 +05:30
Pratyush Choudhary
ad1b28b4a9
Merge branch 'google:main' into readme_table_fix 2023-06-02 00:56:36 +05:30
Niranjan Nilakantan
a5b94f6819 Ignore the .cache directory create by VSCode.
This is populated by the clangd language service provider.

Also ignore the cmake-variants.yaml file.
This can be created locally to select various build/test configurations.

Fixes #4266
2023-06-01 09:48:54 -07:00
Dino Radakovic
06f44bc951 Copy supported platforms from README onto https://google.github.io/googletest/platforms.html
PiperOrigin-RevId: 537016664
Change-Id: Ie62891a1061465a009b90feba0ccb91d85591160
2023-06-01 07:28:42 -07:00
Dino Radakovic
04cf298916 Provide example for setting C++ language standard in GoogleTest's Bazel quickstart and readme.
An equivalent for CMake was merged in aa99ce5a0d

Fixes #4254

PiperOrigin-RevId: 536759641
Change-Id: I8400064a24e0d78f17a0720046f505efa1167b4f
2023-05-31 10:45:43 -07:00
Paul Wankadia
a7833a19bd Update GoogleTest to RE2 release 2023-06-01.
Note that RE2 has taken a dependency on Abseil, so the `main` branch
should be used from now on. The `abseil` branch will go away soon...

PiperOrigin-RevId: 536737543
Change-Id: I0e595ee8e754b924881f997f286cdec3822763bf
2023-05-31 09:33:31 -07:00
Copybara-Service
f625681bc4 Merge pull request #4256 from niranjan-nilakantan:niranjan-nilakantan/issue4255
PiperOrigin-RevId: 536480185
Change-Id: I9bdd65cd18253703abf3cc92b3f354c1f798aa3e
2023-05-30 12:40:46 -07:00
Pro3757
ded275d75e fix README table 2023-05-30 13:50:23 +05:30
niranjan
029d3dddd4 Disable some warnings for IntelLLVM on Windows.
Use /fp:precise to override IntelLLVM's default of /fp:fast.
This makes IsInf and IsNan work as expected by googletest.

```
[build]...\googletest\googlemock\test\gmock-function-mocker_test.cc(143,21): error: 'VoidReturning' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
[build]   MOCK_METHOD(void, VoidReturning, (int n));  // NOLINT
```

```
[build] ...\googletest\googlemock\test\gmock-function-mocker_test.cc(182,20): error: exception specification of overriding function is more lax than base version [-Werror,-Wmicrosoft-exception-spec]
[build]   MOCK_METHOD(int, CTNullary, (), (Calltype(STDMETHODCALLTYPE)));
```

```
[build] ...\googletest\googletest\test\googletest-death-test-test.cc(209,5): error: unused function 'DieInCRTDebugElse12' [-Werror,-Wunused-function]
[build] int DieInCRTDebugElse12(int* sideeffect) {
[build]     ^
```

```
[build] ...\googletest\googletest\test\gtest_unittest.cc(4096,7): error: variable 'n' set but not used [-Werror,-Wunused-but-set-variable]
[build]   int n = 0;
```
2023-05-24 17:33:46 -07:00
Niranjan Nilakantan
e032d57642 Build googletest with IntelLLVM compilers.
Use the same flags as Clang if the compiler id is IntelLLVM.

IntelLLVM warns if a double constant is assigned to a float.

```
[build] .../googletest/googletest/include/gtest/gtest-printers.h:516:17: warning: implicit conversion between floating point types of different sizes [-Wimplicit-float-size-conversion]
[build]       mulfor6 = 1e1;
```

IntelLLVM uses fp-model=fast by default, breaking IsNan and IsInf tests.
Use -ffp-model=precise to fix this.

IntelLLVM does not support -Wchar-subscripts

Fixes #4255
2023-05-24 12:48:51 -07:00
Copybara-Service
4580469122 Merge pull request #4250 from shlomnissan:cmake-quickstart-update
PiperOrigin-RevId: 534150776
Change-Id: Ib6c07c6abd06c259494928102e2cb800b6652612
2023-05-22 12:41:47 -07:00
Shlomi Nissan
aa99ce5a0d Add CXX_STANDARD_REQUIRED to CMake quickstart 2023-05-21 16:40:06 -07:00
Dino Radakovic
cb455a71fb Fix typo in version number example in README
PiperOrigin-RevId: 532796425
Change-Id: If81029216cf12b9b05f8e2d79671ba106ebd28fb
2023-05-17 08:31:17 -07:00
Dino Radakovic
d6fb5e3bf7 Explicitly document googletest release tag format
Fixes #4235

PiperOrigin-RevId: 532446854
Change-Id: If7e1dade02a80d9a30813c136bba3f20c796f0fa
2023-05-16 07:05:45 -07:00
Copybara-Service
60c3602aaa Merge pull request #4231 from yagneshprajapati:main
PiperOrigin-RevId: 532204016
Change-Id: Ifa309f31bb959b43faa54c5ce631a823e6a2888a
2023-05-15 13:17:55 -07:00
Copybara-Service
e42cc2294f Merge pull request #4234 from pateldeev:missing_dep
PiperOrigin-RevId: 532143036
Change-Id: I3dd57e975006478eb6b16b8ea289531738a8a0b5
2023-05-15 09:54:08 -07:00
Abseil Team
bb2941fcc6 Give CreateArgvFromArgs internal linkage
It isn't declared in any header or referenced from any other file.

PiperOrigin-RevId: 531209642
Change-Id: I9e7df37f737b00994f8845ed38c3b775879cb25c
2023-05-11 08:28:20 -07:00
yagneshprajapati
a8e067ae5f
Update README.md
xml report gan removed
2023-05-11 14:57:47 +05:30
yagneshprajapati
7345a66cbd
Update README.md
xUnit link
2023-05-11 14:54:04 +05:30
yagneshprajapati
88295d64a7
Update README.md
xunit link
2023-05-11 14:52:16 +05:30
pateldeev
0eb33cfa5c Add missing absl dependency from build. 2023-05-08 13:02:56 -07:00
yagneshprajapati
a7fa9b3708
Update README.md 2023-05-07 15:22:54 +05:30
Abseil Team
bc860af087 This trips up when compiling with -Wvla otherwise.
PiperOrigin-RevId: 529762901
Change-Id: I6ce4d630191bf265f847aef2d5dcc12a712faa60
2023-05-05 11:05:02 -07:00
Copybara-Service
a3580180d1 Merge pull request #4146 from lygstate:fixes_std_pair_diff
PiperOrigin-RevId: 528781910
Change-Id: I4038332a6255921792bfb4a8098aa84243d48e15
2023-05-02 07:52:02 -07:00
Andy Soffer
76bce79a34
Merge branch 'main' into fixes_std_pair_diff 2023-05-01 14:27:38 -04:00
Copybara-Service
f345b2ca6a Merge pull request #4227 from Vertexwahn:fix-spelling
PiperOrigin-RevId: 528474013
Change-Id: I60cd509aded8d8b02423ea1b07c2c27e3709a808
2023-05-01 08:05:40 -07:00
Dino Radakovic
797b0ad2a3 Use GTEST_INTERNAL_CPLUSPLUS_LANG instead of __cplusplus
Some versions of MSVC provide incorrect values for the latter and rely on _MSVC_LANG instead.
Fixes #4226.

PiperOrigin-RevId: 527919195
Change-Id: Ifcca4612074f5ebc5337094426866a187f79f90a
2023-04-28 10:16:07 -07:00
Tom Hughes
0bdaac5a14 Add qualifier to avoid argument dependent lookup
PiperOrigin-RevId: 527740306
Change-Id: I61308cc232c346d5ff8b0548d4c552a59633fffc
2023-04-27 18:17:59 -07:00
Abseil Team
dea0484e4d Use Abseil Flag public API for flag parsing.
This change brings InitGoogleTest semantic in accordance with the official documentation: only GoogleTest flags are removed from argc/argv. The rest of the flags remains in place. We do nothing special for flags with unrecognized gunit_/gtest_ prefix and we do not report them.

PiperOrigin-RevId: 527257221
Change-Id: Ibb29a1bda1a44251a4ee579c0fb5bbdfd9965c21
2023-04-26 07:13:51 -07:00
Vertexwahn
97408cae55 Fix spelling 2023-04-25 20:20:01 +02:00
Copybara-Service
ccdeec888e Merge pull request #4225 from TurboGawron:non_moveable_struct_fix
PiperOrigin-RevId: 526972449
Change-Id: I77d8bd37807f6c6ab5256f1e6c4abc64cceee740
2023-04-25 08:21:31 -07:00
Patryk Gawroński
51eeae5a55 gmock: fix issue #4222
Rename 'Result' struct to 'NonMoveableStruct' in
gmock-spec-builders_test.cc in ExpectCallTest.NonMoveableType test
2023-04-25 01:45:26 +02:00
Tom Hughes
783d00fd19 Use '=default' to define trivial constructor/destructors
https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html

PiperOrigin-RevId: 526079054
Change-Id: Ia4db21e3e5f58b90de05d52fd94b291ed06d785d
2023-04-21 10:41:25 -07:00
Tom Hughes
baf182e006 Use the empty method to check for emptiness
PiperOrigin-RevId: 526046714
Change-Id: I6ad0deff2a7f6dfef75a643c95ad914c83b9ba38
2023-04-21 08:42:42 -07:00
Tom Hughes
a5308bb992 Add missing std includes
PiperOrigin-RevId: 525850646
Change-Id: I64387f5b933beb79cd05636dca81b7a75213383e
2023-04-20 14:29:09 -07:00
Tom Hughes
9c1efac2a1 Use std::make_unique
PiperOrigin-RevId: 525828947
Change-Id: I66f47c835bc93ba171eba0da8df09eff89c6c77b
2023-04-20 13:09:18 -07:00
Tom Hughes
d7fb5e1af4 Fix spelling
PiperOrigin-RevId: 525820426
Change-Id: Ib5baa8da4a54ebb17b6ace12240ed03eedb46091
2023-04-20 12:36:18 -07:00
Tom Hughes
d8a5fb7ee6 Add missing std includes
PiperOrigin-RevId: 525794940
Change-Id: Ib2639058610c91cbffbb0f22a5e71573e0cbd651
2023-04-20 11:01:56 -07:00
Tom Hughes
01bcf8c70d Make parameter names in function declaration match the names in the
definitions

https://clang.llvm.org/extra/clang-tidy/checks/readability/inconsistent-declaration-parameter-name.html

PiperOrigin-RevId: 525752102
Change-Id: Ibf9d3d1dbae8f95cfc7c6ad29fe4b677f4ee19cf
2023-04-20 08:22:57 -07:00