External/googletest
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix -Wunused-private-field issues with clang

Browse Source 
Provide dummy accessors for private values that are set in initializers,
but not actually used.

Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
This commit is contained in:
Enji Cooper 2019-02-12 16:35:38 -08:00
parent c4ccab33aa
commit ed2fe122f8
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
googlemock/test/gmock-matchers_test.cc
View File

@ -982,6 +982,8 @@ class Unprintable {
Unprintable() : c_('a') {} Unprintable() : c_('a') {}
bool operator==(const Unprintable& /* rhs */) const { return true; } bool operator==(const Unprintable& /* rhs */) const { return true; }
// -Wunused-private-field: dummy accessor for `c_`.
char dummy_c() { return c_; }
private: private:
char c_; char c_;
}; };

2
googletest/test/googletest-param-test-test.cc
View File

@ -964,6 +964,8 @@ INSTANTIATE_TEST_SUITE_P(StatefulNamingFunctor, StatefulNamingTest, Range(0, 5),
class Unstreamable { class Unstreamable {
public: public:
explicit Unstreamable(int value) : value_(value) {} explicit Unstreamable(int value) : value_(value) {}
// -Wunused-private-field: dummy accessor for `value_`.
const int& dummy_value() const { return value_; }
private: private:
int value_; int value_;