From bd47c09b73d40f210238b73f925a8f9196e70675 Mon Sep 17 00:00:00 2001 From: Enji Cooper Date: Fri, 26 Apr 2019 03:59:54 -0700 Subject: [PATCH] Address fallout from -Wsign-conversion work on Windows Some Windows users builds were broken after a0d60be. This change addresses the lingering -Wsign-conversion issues with those platforms by adding some missing `static_cast` calls as needed. Signed-off-by: Enji Cooper --- googletest/src/gtest-port.cc | 2 +- googletest/src/gtest-printers.cc | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/googletest/src/gtest-port.cc b/googletest/src/gtest-port.cc index e5b91fd0..4015a1c1 100644 --- a/googletest/src/gtest-port.cc +++ b/googletest/src/gtest-port.cc @@ -279,7 +279,7 @@ size_t GetThreadCount() { #if GTEST_IS_THREADSAFE && GTEST_OS_WINDOWS void SleepMilliseconds(int n) { - ::Sleep(n); + ::Sleep(static_cast(n)); } AutoHandle::AutoHandle() diff --git a/googletest/src/gtest-printers.cc b/googletest/src/gtest-printers.cc index 40a8817e..a7c5e002 100644 --- a/googletest/src/gtest-printers.cc +++ b/googletest/src/gtest-printers.cc @@ -144,7 +144,8 @@ inline bool IsPrintableAscii(wchar_t c) { // which is the type of c. template static CharFormat PrintAsCharLiteralTo(Char c, ostream* os) { - switch (static_cast(c)) { + wchar_t w_c = static_cast(c); + switch (w_c) { case L'\0': *os << "\\0"; break; @@ -176,7 +177,7 @@ static CharFormat PrintAsCharLiteralTo(Char c, ostream* os) { *os << "\\v"; break; default: - if (IsPrintableAscii(c)) { + if (IsPrintableAscii(w_c)) { *os << static_cast(c); return kAsIs; } else {