External/fmt
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

reuse open_windows_file on ctor

Browse Source
This commit is contained in:
Fros1er 2023-02-15 21:32:37 +08:00
parent 68fa8e7bff
commit e2d56c0949
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/os.cc
View File

@ -223,15 +223,13 @@ file::file(cstring_view path, int oflag) {
# if defined(_WIN32) && !defined(__MINGW32__) # if defined(_WIN32) && !defined(__MINGW32__)
fd_ = -1; fd_ = -1;
auto converted = detail::utf8_to_utf16(string_view(path.c_str())); auto converted = detail::utf8_to_utf16(string_view(path.c_str()));
auto err = *this = file::open_windows_file(converted.c_str(), oflag);
_wsopen_s(&fd_, converted.c_str(), oflag, _SH_DENYNO, default_open_mode);
# else # else
FMT_RETRY(fd_, FMT_POSIX_CALL(open(path.c_str(), oflag, default_open_mode))); FMT_RETRY(fd_, FMT_POSIX_CALL(open(path.c_str(), oflag, default_open_mode)));
auto err = errno;
# endif
if (fd_ == -1) if (fd_ == -1)
FMT_THROW( FMT_THROW(
system_error(err, FMT_STRING("cannot open file {}"), path.c_str())); system_error(errno, FMT_STRING("cannot open file {}"), path.c_str()));
# endif
} }
file::~file() noexcept { file::~file() noexcept {