External/fmt
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[clang-tidy] use trailing return types

Browse Source 
Found with modernize-use-trailing-return-type

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2020-05-07 18:51:11 -07:00
parent 41777279ab
commit ccfb50166a
No known key found for this signature in database
GPG Key ID: 36D31CFA845F0E3B
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/format.cc
View File

@ -11,8 +11,8 @@ FMT_BEGIN_NAMESPACE
namespace internal { namespace internal {
template <typename T> template <typename T>
int format_float(char* buf, std::size_t size, const char* format, int precision, auto format_float(char* buf, std::size_t size, const char* format, int precision,
T value) { T value) -> int {
#ifdef FMT_FUZZ #ifdef FMT_FUZZ
if (precision > 100000) if (precision > 100000)
throw std::runtime_error( throw std::runtime_error(

16
src/os.cc
View File

@ -66,7 +66,7 @@ inline unsigned convert_rwcount(std::size_t count) {
// Return type of read and write functions. // Return type of read and write functions.
using RWResult = ssize_t; using RWResult = ssize_t;
inline std::size_t convert_rwcount(std::size_t count) { return count; } inline auto convert_rwcount(std::size_t count) -> std::size_t { return count; }
#endif #endif
} // namespace } // namespace
@ -166,7 +166,7 @@ void buffered_file::close() {
// A macro used to prevent expansion of fileno on broken versions of MinGW. // A macro used to prevent expansion of fileno on broken versions of MinGW.
#define FMT_ARGS #define FMT_ARGS
int buffered_file::fileno() const { auto buffered_file::fileno() const -> int {
int fd = FMT_POSIX_CALL(fileno FMT_ARGS(file_)); int fd = FMT_POSIX_CALL(fileno FMT_ARGS(file_));
if (fd == -1) FMT_THROW(system_error(errno, "cannot get file descriptor")); if (fd == -1) FMT_THROW(system_error(errno, "cannot get file descriptor"));
return fd; return fd;
@ -201,7 +201,7 @@ void file::close() {
if (result != 0) FMT_THROW(system_error(errno, "cannot close file")); if (result != 0) FMT_THROW(system_error(errno, "cannot close file"));
} }
long long file::size() const { auto file::size() const -> long long {
# ifdef _WIN32 # ifdef _WIN32
// Use GetFileSize instead of GetFileSizeEx for the case when _WIN32_WINNT // Use GetFileSize instead of GetFileSizeEx for the case when _WIN32_WINNT
// is less than 0x0500 as is the case with some default MinGW builds. // is less than 0x0500 as is the case with some default MinGW builds.
@ -227,21 +227,21 @@ long long file::size() const {
# endif # endif
} }
std::size_t file::read(void* buffer, std::size_t count) const { auto file::read(void* buffer, std::size_t count) const -> std::size_t {
RWResult result = 0; RWResult result = 0;
FMT_RETRY(result, FMT_POSIX_CALL(read(fd_, buffer, convert_rwcount(count)))); FMT_RETRY(result, FMT_POSIX_CALL(read(fd_, buffer, convert_rwcount(count))));
if (result < 0) FMT_THROW(system_error(errno, "cannot read from file")); if (result < 0) FMT_THROW(system_error(errno, "cannot read from file"));
return internal::to_unsigned(result); return internal::to_unsigned(result);
} }
std::size_t file::write(const void* buffer, std::size_t count) const { auto file::write(const void* buffer, std::size_t count) const -> std::size_t {
RWResult result = 0; RWResult result = 0;
FMT_RETRY(result, FMT_POSIX_CALL(write(fd_, buffer, convert_rwcount(count)))); FMT_RETRY(result, FMT_POSIX_CALL(write(fd_, buffer, convert_rwcount(count))));
if (result < 0) FMT_THROW(system_error(errno, "cannot write to file")); if (result < 0) FMT_THROW(system_error(errno, "cannot write to file"));
return internal::to_unsigned(result); return internal::to_unsigned(result);
} }
file file::dup(int fd) { auto file::dup(int fd) -> file {
// Don't retry as dup doesn't return EINTR. // Don't retry as dup doesn't return EINTR.
// http://pubs.opengroup.org/onlinepubs/009695399/functions/dup.html // http://pubs.opengroup.org/onlinepubs/009695399/functions/dup.html
int new_fd = FMT_POSIX_CALL(dup(fd)); int new_fd = FMT_POSIX_CALL(dup(fd));
@ -287,7 +287,7 @@ void file::pipe(file& read_end, file& write_end) {
write_end = file(fds[1]); write_end = file(fds[1]);
} }
buffered_file file::fdopen(const char* mode) { auto file::fdopen(const char* mode) -> buffered_file {
// Don't retry as fdopen doesn't return EINTR. // Don't retry as fdopen doesn't return EINTR.
FILE* f = FMT_POSIX_CALL(fdopen(fd_, mode)); FILE* f = FMT_POSIX_CALL(fdopen(fd_, mode));
if (!f) if (!f)
@ -298,7 +298,7 @@ buffered_file file::fdopen(const char* mode) {
return bf; return bf;
} }
long getpagesize() { auto getpagesize() -> long {
# ifdef _WIN32 # ifdef _WIN32
SYSTEM_INFO si; SYSTEM_INFO si;
GetSystemInfo(&si); GetSystemInfo(&si);