External/fmt
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

format-inl.h: fixing compare double with 0

Browse Source 
If compiling with -Wfloat-equal, I get the following error:
    comparing floating point with == or != is unsafe [-Werror=float-equal]
This commit is contained in:
Martin Wührer 2019-01-29 19:01:50 +01:00
parent 0700612249
commit cb96ade13a
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
include/fmt/format-inl.h
View File

@ -717,11 +717,17 @@ FMT_FUNC gen_digits_params process_specs(const core_format_specs& specs,
return params; return params;
} }
inline bool almost_zero(const double x, const std::size_t ulp)
{
// Inspired from https://en.cppreference.com/w/cpp/types/numeric_limits/epsilon
return std::abs(x) <= std::numeric_limits<double>::epsilon() * std::abs(x) * static_cast<double>(ulp);
}
template <typename Double> template <typename Double>
FMT_FUNC typename std::enable_if<sizeof(Double) == sizeof(uint64_t), bool>::type FMT_FUNC typename std::enable_if<sizeof(Double) == sizeof(uint64_t), bool>::type
grisu2_format(Double value, buffer& buf, core_format_specs specs) { grisu2_format(Double value, buffer& buf, core_format_specs specs) {
FMT_ASSERT(value >= 0, "value is negative"); FMT_ASSERT(value >= 0, "value is negative");
if (value == 0) { if (almost_zero(value, 1)) {
gen_digits_params params = process_specs(specs, 1, buf); gen_digits_params params = process_specs(specs, 1, buf);
const size_t size = 1; const size_t size = 1;
buf[0] = '0'; buf[0] = '0';