diff --git a/format.cc b/format.cc index 0c2946f7..144a8e5c 100644 --- a/format.cc +++ b/format.cc @@ -559,7 +559,7 @@ void fmt::BasicWriter::write_str( template inline const Arg - &fmt::internal::FormatParser::ParseArgIndex(const Char *&s) { + &fmt::BasicFormatter::ParseArgIndex(const Char *&s) { unsigned arg_index = 0; if (*s < '0' || *s > '9') { if (*s != '}' && *s != ':') @@ -586,7 +586,7 @@ inline const Arg } template -void fmt::internal::FormatParser::CheckSign( +void fmt::BasicFormatter::CheckSign( const Char *&s, const Arg &arg) { char sign = static_cast(*s); if (arg.type > Arg::LAST_NUMERIC_TYPE) { @@ -868,7 +868,7 @@ void fmt::internal::PrintfParser::Format( } template -const Char *fmt::internal::FormatParser::format( +const Char *fmt::BasicFormatter::format( const Char *format_str, const internal::Arg &arg) { const Char *s = format_str; const char *error = 0; @@ -1073,7 +1073,7 @@ const Char *fmt::internal::FormatParser::format( } template -void fmt::internal::FormatParser::Format( +void fmt::BasicFormatter::Format( BasicStringRef format_str, const ArgList &args) { const Char *s = start_ = format_str.c_str(); args_ = args; @@ -1142,7 +1142,7 @@ template fmt::BasicWriter::CharPtr fmt::BasicWriter::FillPadding(CharPtr buffer, unsigned total_size, std::size_t content_size, wchar_t fill); -template void fmt::internal::FormatParser::Format( +template void fmt::BasicFormatter::Format( BasicStringRef format, const ArgList &args); template void fmt::internal::PrintfParser::Format( @@ -1154,7 +1154,7 @@ template fmt::BasicWriter::CharPtr fmt::BasicWriter::FillPadding(CharPtr buffer, unsigned total_size, std::size_t content_size, wchar_t fill); -template void fmt::internal::FormatParser::Format( +template void fmt::BasicFormatter::Format( BasicStringRef format, const ArgList &args); template void fmt::internal::PrintfParser::Format( diff --git a/format.h b/format.h index 0d7a6ff9..ff1b5dbe 100644 --- a/format.h +++ b/format.h @@ -130,13 +130,11 @@ typedef BasicWriter WWriter; struct FormatSpec; -namespace internal { template -class FormatParser; -} +class BasicFormatter; template -void format(internal::FormatParser &f, const Char *format_str, const T &value); +void format(BasicFormatter &f, const Char *format_str, const T &value); /** \rst @@ -654,7 +652,7 @@ class MakeArg : public Arg { template static void format_custom_arg( void *formatter, const void *arg, const void *format_str) { - format(*static_cast*>(formatter), + format(*static_cast*>(formatter), static_cast(format_str), *static_cast(arg)); } @@ -751,17 +749,15 @@ class ArgList { } }; -namespace internal { -// Format string parser. -// TODO: rename to Formatter +// A formatter. template -class FormatParser { +class BasicFormatter { private: BasicWriter &writer_; ArgList args_; int next_arg_index_; const Char *start_; - fmt::internal::FormatErrorReporter report_error_; + internal::FormatErrorReporter report_error_; // Parses argument index and returns an argument with this index. const internal::Arg &ParseArgIndex(const Char *&s); @@ -769,7 +765,7 @@ private: void CheckSign(const Char *&s, const internal::Arg &arg); public: - explicit FormatParser(BasicWriter &w) : writer_(w) {} + explicit BasicFormatter(BasicWriter &w) : writer_(w) {} BasicWriter &writer() { return writer_; } @@ -778,6 +774,7 @@ public: const Char *format(const Char *format_str, const internal::Arg &arg); }; +namespace internal { // Printf format string parser. template class PrintfParser { @@ -1256,7 +1253,7 @@ class BasicWriter { // Do not implement! void operator<<(typename internal::CharTraits::UnsupportedStrType); - friend class internal::FormatParser; + friend class BasicFormatter; friend class internal::PrintfParser; public: @@ -1337,7 +1334,7 @@ class BasicWriter { \endrst */ void write(BasicStringRef format, const ArgList &args) { - internal::FormatParser(*this).Format(format, args); + BasicFormatter(*this).Format(format, args); } FMT_VARIADIC_VOID(write, fmt::BasicStringRef) @@ -1588,8 +1585,7 @@ void BasicWriter::FormatInt(T value, const Spec &spec) { // Formats a value. template -void format(internal::FormatParser &f, - const Char *format_str, const T &value) { +void format(BasicFormatter &f, const Char *format_str, const T &value) { std::basic_ostringstream os; os << value; f.format(format_str, internal::MakeArg(os.str())); diff --git a/test/format-test.cc b/test/format-test.cc index 8318d973..24239336 100644 --- a/test/format-test.cc +++ b/test/format-test.cc @@ -1318,7 +1318,7 @@ TEST(FormatterTest, FormatUsingIOStreams) { class Answer {}; template -void format(fmt::internal::FormatParser &f, const Char *, Answer) { +void format(fmt::BasicFormatter &f, const Char *, Answer) { f.writer() << "42"; } diff --git a/test/util-test.cc b/test/util-test.cc index d07fd192..9952f64c 100644 --- a/test/util-test.cc +++ b/test/util-test.cc @@ -185,7 +185,7 @@ TEST(UtilTest, MakeArg) { EXPECT_EQ(fmt::internal::Arg::CUSTOM, arg.type); arg.custom.value = &t; fmt::Writer w; - fmt::internal::FormatParser formatter(w); + fmt::BasicFormatter formatter(w); arg.custom.format(&formatter, &t, "}"); EXPECT_EQ("test", w.str()); }