Replace a bunch of craft with type_traits, take 2

include/fmt/core.h

@@ -338,36 +338,11 @@ inline void require_wchar() {
       "formatting of wide characters into a narrow output is disallowed");
 }
 
-using yes = char[1];
-using no = char[2];
-
-yes &convert(unsigned long long);
-no &convert(...);
-
-template<typename T, bool ENABLE_CONVERSION>
-struct convert_to_int_impl {
-  enum { value = ENABLE_CONVERSION };
-};
-
-template<typename T, bool ENABLE_CONVERSION>
-struct convert_to_int_impl2 {
-  enum { value = false };
-};
-
-template<typename T>
-struct convert_to_int_impl2<T, true> {
-  enum {
-    // Don't convert arithmetic types.
-    value = convert_to_int_impl<T, !std::is_arithmetic<T>::value>::value
-  };
-};
-
-template<typename T>
+template <typename T, bool ENABLE = true>
 struct convert_to_int {
   enum {
-    enable_conversion = sizeof(convert(std::declval<T>())) == sizeof(yes)
+   value = !std::is_arithmetic<T>::value && std::is_convertible<T, int>::value
   };
-  enum { value = convert_to_int_impl2<T, enable_conversion>::value };
 };
 
 #define FMT_DISABLE_CONVERSION_TO_INT(Type) \

include/fmt/ostream.h

@@ -47,23 +47,28 @@ class FormatBuf : public std::basic_streambuf<Char> {
   }
 };
 
-yes &convert(std::ostream &);
-
-struct DummyStream : std::ostream {
-  DummyStream();  // Suppress a bogus warning in MSVC.
-  // Hide all operator<< overloads from std::ostream.
-  void operator<<(null<>);
+struct test_stream : std::ostream {
+ private:
+  struct null;
+  // Hide all operator<< from std::ostream.
+  void operator<<(null);
 };
 
-no &operator<<(std::ostream &, int);
+// Disable conversion to int if T has an overloaded operator<< which is a free
+// function (not a member of std::ostream).
+template <typename T>
+class convert_to_int<T, true> {
+ private:
+  template <typename U>
+  static decltype(
+    std::declval<test_stream&>() << std::declval<U>(), std::true_type())
+      test(int);
 
-template<typename T>
-struct convert_to_int_impl<T, true> {
-  // Convert to int only if T doesn't have an overloaded operator<<.
-  enum {
-    value = sizeof(convert(std::declval<DummyStream&>() << std::declval<T>()))
-            == sizeof(no)
-  };
+  template <typename>
+  static std::false_type test(...);
+
+ public:
+  static const bool value = !decltype(test<T>(0))::value;
 };
 
 // Write the content of buf to os.

test/util-test.cc

@@ -827,15 +827,15 @@ TEST(UtilTest, ReportWindowsError) {
 enum TestEnum2 {};
 
 TEST(UtilTest, ConvertToInt) {
-  EXPECT_TRUE(fmt::internal::convert_to_int<char>::enable_conversion);
-  EXPECT_FALSE(fmt::internal::convert_to_int<const char *>::enable_conversion);
+  EXPECT_FALSE(fmt::internal::convert_to_int<char>::value);
+  EXPECT_FALSE(fmt::internal::convert_to_int<const char *>::value);
   EXPECT_TRUE(fmt::internal::convert_to_int<TestEnum2>::value);
 }
 
 #if FMT_USE_ENUM_BASE
 enum TestEnum : char {TestValue};
 TEST(UtilTest, IsEnumConvertibleToInt) {
-  EXPECT_TRUE(fmt::internal::convert_to_int<TestEnum>::enable_conversion);
+  EXPECT_TRUE(fmt::internal::convert_to_int<TestEnum>::value);
 }
 #endif