External/fmt
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix clang -Wsign-conversion warning in bigint::remove_leading_zeros.

Browse Source 
Rather than subtracting 1 from the size before the loop, and potentially going negative, the loop can test there is at least one element before subtracting for the dereference.
This commit is contained in:
Dair Grant 2020-03-02 14:17:23 +00:00
parent 1e8493196e
commit 8f2ded910e
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
include/fmt/format-inl.h
View File

@ -515,9 +515,12 @@ class bigint {
}
void remove_leading_zeros() {
int num_bigits = static_cast<int>(bigits_.size()) - 1;
while (num_bigits > 0 && bigits_[num_bigits] == 0) --num_bigits;
bigits_.resize(num_bigits + 1);
size_t old_bigits = bigits_.size();
size_t new_bigits = old_bigits;
while (new_bigits > 1 && bigits_[new_bigits-1] == 0) --new_bigits;
if (new_bigits != old_bigits) {
bigits_.resize(new_bigits);
}
}
// Computes *this -= other assuming aligned bigints and *this >= other.