External/fmt
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid weak vtables by providing a private virtual member function

Browse Source
This commit is contained in:
Deniz Evrenci 2019-10-10 23:42:02 +09:00
parent 2730e90186
commit 88430d7837
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/core-test.cc
View File

@ -127,8 +127,13 @@ TEST(BufferTest, Ctor) {
struct dying_buffer : test_buffer<int> { struct dying_buffer : test_buffer<int> {
MOCK_METHOD0(die, void()); MOCK_METHOD0(die, void());
~dying_buffer() { die(); } ~dying_buffer() { die(); }
private:
virtual void avoid_weak_vtable();
}; };
void dying_buffer::avoid_weak_vtable() {}
TEST(BufferTest, VirtualDtor) { TEST(BufferTest, VirtualDtor) {
typedef StrictMock<dying_buffer> stict_mock_buffer; typedef StrictMock<dying_buffer> stict_mock_buffer;
stict_mock_buffer* mock_buffer = new stict_mock_buffer(); stict_mock_buffer* mock_buffer = new stict_mock_buffer();

5
test/test-assert.h
View File

@ -14,8 +14,13 @@
class assertion_failure : public std::logic_error { class assertion_failure : public std::logic_error {
public: public:
explicit assertion_failure(const char* message) : std::logic_error(message) {} explicit assertion_failure(const char* message) : std::logic_error(message) {}
private:
virtual void avoid_weak_vtable();
}; };
void assertion_failure::avoid_weak_vtable() {}
#define FMT_ASSERT(condition, message) \ #define FMT_ASSERT(condition, message) \
if (!(condition)) throw assertion_failure(message); if (!(condition)) throw assertion_failure(message);