External/fmt
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make underlying type of align_t / sign_t unsigned.

Browse Source 
When building with -Werror,-Wsigned-enum-bitfield clang reports that "enums in the Microsoft ABI are signed integers by default; consider giving the enum type an unsigned underlying type to make this code portable" for these two types.

Under this ABI one bit of an enum bitfield is used by the sign bit. Enum values large enough to overlap that bit would be seen as negative integers if read out into an integer.

There may not be any such reading out at present, but making the underlying type unsigned ensures consistent results across platforms.
This commit is contained in:
Dair Grant 2020-03-01 00:25:59 +00:00
parent bed134a4aa
commit 7e972dd8f8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/fmt/format.h
View File

@ -997,12 +997,12 @@ template <typename Char> struct fill_t {
// We cannot use enum classes as bit fields because of a gcc bug // We cannot use enum classes as bit fields because of a gcc bug
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61414. // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61414.
namespace align { namespace align {
enum type { none, left, right, center, numeric }; enum type : uint8_t { none, left, right, center, numeric };
} }
using align_t = align::type; using align_t = align::type;
namespace sign { namespace sign {
enum type { none, minus, plus, space }; enum type : uint8_t { none, minus, plus, space };
} }
using sign_t = sign::type; using sign_t = sign::type;