From 4fa0c9a1ce042bd92a6b64e8d17916ffc628aba5 Mon Sep 17 00:00:00 2001 From: Dair Grant Date: Mon, 2 Mar 2020 14:09:50 +0000 Subject: [PATCH] Fix clang -Wsign-conversion warning in fallback_format. num_digits is initialised to 0, and is always incremented by 1 prior to useage where at most 1 is subtracted from it. --- include/fmt/format-inl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/fmt/format-inl.h b/include/fmt/format-inl.h index 4ad4df4c..0318e559 100644 --- a/include/fmt/format-inl.h +++ b/include/fmt/format-inl.h @@ -1004,7 +1004,7 @@ void fallback_format(Double d, buffer& buf, int& exp10) { if (!upper) upper = &lower; // Invariant: value == (numerator / denominator) * pow(10, exp10). bool even = (value.f & 1) == 0; - int num_digits = 0; + size_t num_digits = 0; char* data = buf.data(); for (;;) { int digit = numerator.divmod_assign(denominator);