From 400a0a57270231cd87cd80a1633b15db21b2f2ad Mon Sep 17 00:00:00 2001 From: denchat <19730041+denchat@users.noreply.github.com> Date: Mon, 12 Apr 2021 22:17:26 +0700 Subject: [PATCH] Add a comment about clang Add a comment that clang now doesn't allow dllexport on template instantiation definitions. Mark them on tempalte instantiation declarations instead (in format.h). [MinGW] Fix dllexport of explicit template instantiation https://reviews.llvm.org/D61118 --- src/format.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/format.cc b/src/format.cc index 22fda622..e75e1724 100644 --- a/src/format.cc +++ b/src/format.cc @@ -55,6 +55,7 @@ vformat_to(buffer&, string_view, type_identity_t>>); } // namespace detail +// Clang doesn't allow dllexport on template instantiation definitions (LLVM D61118) template struct detail::basic_data; // Workaround a bug in MSVC2013 that prevents instantiation of format_float.