External/fmt
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Better fix for all compilers

Browse Source 
The Nvidia compiler complained about unreachable code with original throw followed by return 0.  However, if the return 0 was removed, then the MSC compiler complained about function not returning value. This was due to the use of `FMT_THROW` which "tricks" the MSC compiler into thinking it is possible for the `FMT_THROW` to return.  

If we just use the `thow format_error(...)` here with no return, then all compilers should be able to deduce that the code will not return following the explicit throw and it should eliminate all warnings from Nvidia, MSC, and other compilers.
This commit is contained in:
Greg Sjaardema 2019-12-15 08:49:51 -07:00 committed by GitHub
parent 6a920477f9
commit 22cc84ab23
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
include/fmt/printf.h
View File

@ -45,10 +45,7 @@ class printf_precision_handler {
template <typename T, FMT_ENABLE_IF(!std::is_integral<T>::value)> template <typename T, FMT_ENABLE_IF(!std::is_integral<T>::value)>
int operator()(T) { int operator()(T) {
FMT_THROW(format_error("precision is not integer")); throw format_error("precision is not integer");
#if FMT_MSC_VER
return 0;
#endif
} }
}; };
@ -168,10 +165,7 @@ template <typename Char> class printf_width_handler {
template <typename T, FMT_ENABLE_IF(!std::is_integral<T>::value)> template <typename T, FMT_ENABLE_IF(!std::is_integral<T>::value)>
unsigned operator()(T) { unsigned operator()(T) {
FMT_THROW(format_error("width is not integer")); throw format_error("width is not integer");
#if FMT_MSC_VER
return 0;
#endif
} }
}; };