diff --git a/doc/api.rst b/doc/api.rst index b0069f0c..54895190 100644 --- a/doc/api.rst +++ b/doc/api.rst @@ -120,19 +120,17 @@ custom argument formatter class:: // A custom argument formatter that formats negative integers as unsigned // with the ``x`` format specifier. class CustomArgFormatter : - public fmt::BasicArgFormatter { + public fmt::BasicArgFormatter { public: CustomArgFormatter(fmt::BasicFormatter &f, fmt::FormatSpec &s, const char *fmt) - : fmt::BasicArgFormatter(f, s, fmt) {} + : fmt::BasicArgFormatter(f, s, fmt) {} void visit_int(int value) { if (spec().type() == 'x') visit_uint(value); // convert to unsigned and format else - fmt::BasicArgFormatter::visit_int(value); + fmt::BasicArgFormatter::visit_int(value); } }; diff --git a/fmt/format.h b/fmt/format.h index 786e1c26..8d3e694d 100644 --- a/fmt/format.h +++ b/fmt/format.h @@ -431,7 +431,7 @@ typedef BasicWriter WWriter; template class ArgFormatter; -template +template class BasicPrintfArgFormatter; template +template class ArgFormatterBase : public ArgVisitor { private: BasicWriter &writer_; @@ -2091,7 +2091,7 @@ class FormatterBase { will be called. \endrst */ -template +template class BasicArgFormatter : public internal::ArgFormatterBase { private: BasicFormatter &formatter_; diff --git a/test/custom-formatter-test.cc b/test/custom-formatter-test.cc index 31edc90a..f662b191 100644 --- a/test/custom-formatter-test.cc +++ b/test/custom-formatter-test.cc @@ -15,29 +15,25 @@ using fmt::BasicPrintfArgFormatter; // A custom argument formatter that doesn't print `-` for floating-point values // rounded to 0. class CustomArgFormatter : - public fmt::BasicArgFormatter { + public fmt::BasicArgFormatter { public: CustomArgFormatter(fmt::BasicFormatter &f, fmt::FormatSpec &s, const char *fmt) - : fmt::BasicArgFormatter(f, s, fmt) {} + : fmt::BasicArgFormatter(f, s, fmt) {} void visit_double(double value) { if (round(value * pow(10, spec().precision())) == 0) value = 0; - fmt::BasicArgFormatter::visit_double(value); + fmt::BasicArgFormatter::visit_double(value); } }; // A custom argument formatter that doesn't print `-` for floating-point values // rounded to 0. class CustomPrintfArgFormatter : - public BasicPrintfArgFormatter { + public BasicPrintfArgFormatter { public: - typedef BasicPrintfArgFormatter Base; + typedef BasicPrintfArgFormatter Base; CustomPrintfArgFormatter(fmt::BasicWriter &w, fmt::FormatSpec &spec) : Base(w, spec) {} diff --git a/test/format-test.cc b/test/format-test.cc index 2d23bde6..6d4a8fcd 100644 --- a/test/format-test.cc +++ b/test/format-test.cc @@ -1630,16 +1630,13 @@ TEST(FormatTest, Enum) { } class MockArgFormatter : - public fmt::internal::ArgFormatterBase { + public fmt::internal::ArgFormatterBase { public: - typedef fmt::internal::ArgFormatterBase Base; + typedef fmt::internal::ArgFormatterBase Base; MockArgFormatter(fmt::BasicFormatter &f, fmt::FormatSpec &s, const char *) - : fmt::internal::ArgFormatterBase(f.writer(), s) { + : fmt::internal::ArgFormatterBase(f.writer(), s) { EXPECT_CALL(*this, visit_int(42)); } @@ -1663,4 +1660,3 @@ void convert(int); TEST(FormatTest, ConvertCollision) { fmt::format("{}", 42); } - diff --git a/test/ostream-test.cc b/test/ostream-test.cc index e6b781af..4081b43f 100644 --- a/test/ostream-test.cc +++ b/test/ostream-test.cc @@ -58,12 +58,10 @@ TEST(OStreamTest, Enum) { EXPECT_EQ("0", fmt::format("{}", A)); } -struct TestArgFormatter : - fmt::BasicArgFormatter { +struct TestArgFormatter : fmt::BasicArgFormatter { TestArgFormatter(fmt::BasicFormatter &f, fmt::FormatSpec &s, const char *fmt) - : fmt::BasicArgFormatter(f, s, fmt) {} + : fmt::BasicArgFormatter(f, s, fmt) {} }; TEST(OStreamTest, CustomArg) {