Commit Graph

21 Commits

Author SHA1 Message Date
DevCodeOne
d7b930846c Fix some strange issues in integer_parser (#80)
* Prevent malformed numbers from being parsed as correct numbers.

Fixes #78. If you passed a string for example "test" it would get parsed to 1400.
The problem was that the parser did not throw an exception when an incorrect char was encountered.
Also a number without 0x in front with hexadecimal digits in it got parsed.
The number was treated as a hexadecimal number but it was still calculated with base 10.
So now before the current char is used, it is checked if it is valid in the current base.
Furthermore the number 0x0 was not a valid number, it now is a special case in the `integer_pattern`.

* Fixed `integer_pattern` so it works correctly under clang. Added testcase for invalid integers and for 0x0 being a valid number.
2017-11-02 08:14:21 +11:00
Alcaro
8ce9a587fa __GNU__ isn't a thing (#79)
Fixes a typo that never unsilenced the non virtual destructor warning.
2017-11-01 08:07:28 +11:00
Benjamin Buch
37fab4ee7a avoid warning about non-virtual destructor (#75)
´Value´ and ´standard_value´ don't have a virtual destructor. When I understand the code right, this is intended, because they are used through ´shared_ptr´ and so its not required. Nevertheless, clang does warn about it, since at the point of the destructor call it can not check if the object has a final type. Adding the C++11 keyword ´final´ to ´standard_value´ avoids this warning.
2017-10-10 11:58:40 +11:00
Jarryd Beck
0b7686949d Fix compiler warnings for MSVC
Fixes #62. This fixes compiler warnings that are raised by MSVC.

In one case the code that was warned about was never executed, but
this compiles it out in that case to silence the warning.
2017-09-04 17:55:52 +10:00
Jarryd Beck
1e51db16b5 Minor tweaks 2017-08-29 18:20:28 +10:00
giumas
52e2f8b140 Remove curly single-quotes only on Windows (#68)
This uses normal single quotes when on a Windows platform.
2017-08-29 18:16:28 +10:00
Hannah Rittich
2aed1ce41b Added parsing of general types. (#63)
Adds generic parsing of types using `operator>>`, in particular allows
parsing of floats and doubles.
2017-08-16 17:55:06 +10:00
Jarryd Beck
da9210d41e fix multiple definitions
Fixes #61. Commit 5e9f822598 introduced
duplicate definitions across separate translation units.
2017-08-08 08:12:31 +10:00
Jarryd Beck
5e9f822598 Improve integer parsing
Fixes #39. Closes #40. This is an overhaul of the way that integer
arguments are parsed. Instead of using std::istream, which allows,
for example, negative integers for unsigned types, we use our own
parser.

This allows us to do proper range checking depending on the type,
and to correctly check for negative values passed to unsigned types.

This also allows the handling of base 16 numbers.
2017-07-25 08:12:29 +10:00
Shivakar Vulli
f931fd4279 Allow spaces in option specification. (#58)
Fixes #57.

Allows spaces after the comma between the short and long option
specification.
2017-07-16 15:11:03 +10:00
Dominic Cupo
a3a1363b6b Added inline to check_required (#51)
This alleviated an issue I had where during compilation, check_required was defined multiple times
2017-06-06 10:24:38 +10:00
Jarryd Beck
34aec8e87c Enable warnings and fix them
Fixes #50. This enables -Wall -Wextra -Wshadow and sets -Werror so that
the build fails if there are any warnings. All warnings that came up are
also fixed
2017-06-01 17:12:17 +10:00
Jarryd Beck
464a8eb65d Add required options helper
Fixes #44. Adds a helper function for checking required options.
2017-05-31 18:10:46 +10:00
Jarryd Beck
9d16b98edd Support only short option
Fixes #47. Adds support for options that only have a short option.
2017-05-31 17:40:14 +10:00
Jarryd Beck
77b1b43a7c remove redundant namespace block 2017-05-31 17:25:46 +10:00
Jarryd Beck
3fa0f6caa0 some cleanup
cleanup some code smells
2017-05-31 07:35:35 +10:00
Jarryd Beck
9db62cb338 Fix broken implicit_value when given empty
Fixes #46. When an option had an implicit value, and an empty string was
passed on the command line, the implicit value would be used instead.
2017-05-18 18:06:52 +10:00
Jarryd Beck
848880d931 Fix arguments after -- without declared positional
Fixes #36. This fixes handling arguments passed after `--` when no
positional arguments have been declared, or when the positional
arguments have all been used up. The bug was that the extra arguments
were lost. Now they are retained in the modified argv.
2017-05-06 14:16:00 +10:00
Torben Jonas
21591dc8e8 Conditionally output all help groups on empty groups vector (#42)
* Conditionally output all help groups on empty groups vector

* Fix formatting
2017-05-02 07:40:45 +10:00
Jarryd Beck
3c3d2003ca add help for positional parameters 2017-04-26 18:16:00 +10:00
Mario Badr
e005d07656 Use cmake interface library
Fixes #33.

This PR uses cmake's interface library feature:

  An INTERFACE library target does not directly create build output,
  though it may have properties set on it and it may be installed,
  exported and imported.

This makes it easier to include the header only library in a cmake
project. After using add_subdirectory on the cxxopts directory, one
simply needs to include cxxopts in their target_link_libraries, which
will allow the user's target to inherit the properties of the cxxopts
header library (see changes to example and test).
2016-12-03 07:50:14 +11:00