External/cxxopts
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

| should be inside of (…) (#87)

Browse Source 
* `|` should be inside of `(…)`

It's possible to use `(t|true|T|True)` as `truthy_pattern` but still failing `true` as a truthy under my environment :-(

```
Apple LLVM version 8.0.0 (clang-800.0.42.1)
Target: x86_64-apple-darwin15.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
```
This commit is contained in:
Masashi Fujita 2017-12-04 16:15:20 +09:00 committed by jarro2783
parent fab3bae2ff
commit ec9e62c2c8
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/cxxopts.hpp
View File

@ -444,9 +444,9 @@ namespace cxxopts
std::basic_regex<char> integer_pattern
("(-)?(0x)?([1-9a-zA-Z][0-9a-zA-Z]*)|((0x)?0)");
std::basic_regex<char> truthy_pattern
("t|true|T|True");
("(t|T)(rue)?");
std::basic_regex<char> falsy_pattern
("(f|false|F|False)?");
("((f|F)(alse)?)?");
}
namespace detail
@ -1570,7 +1570,7 @@ ParseResult::consume_positional(std::string a)
if (iter != m_options.end())
{
auto& result = m_results[iter->second];
if (!iter->second->value().is_container())
if (!iter->second->value().is_container())
{
if (result.count() == 0)
{