The `#pragma GCC diagnostic push' should be used before setting up the temporary environment.

This commit is contained in:
RonxBulld 2021-04-21 14:39:49 +08:00
parent be35921b3f
commit e01352fabe

View File

@ -288,9 +288,9 @@ namespace cxxopts
#if defined(__GNUC__) #if defined(__GNUC__)
// GNU GCC with -Weffc++ will issue a warning regarding the upcoming class, we want to silence it: // GNU GCC with -Weffc++ will issue a warning regarding the upcoming class, we want to silence it:
// warning: base class 'class std::enable_shared_from_this<cxxopts::Value>' has accessible non-virtual destructor // warning: base class 'class std::enable_shared_from_this<cxxopts::Value>' has accessible non-virtual destructor
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wnon-virtual-dtor" #pragma GCC diagnostic ignored "-Wnon-virtual-dtor"
#pragma GCC diagnostic ignored "-Weffc++" #pragma GCC diagnostic ignored "-Weffc++"
#pragma GCC diagnostic push
// This will be ignored under other compilers like LLVM clang. // This will be ignored under other compilers like LLVM clang.
#endif #endif
class Value : public std::enable_shared_from_this<Value> class Value : public std::enable_shared_from_this<Value>