GCC prior to 5.0 should ignore not only -Wnon-virtual-dtor but also -Weffc++, otherwise non-virtual destructor problems will still be reported.

This commit is contained in:
RonxBulld 2021-04-21 14:37:58 +08:00
parent 45ecbf5068
commit be35921b3f

View File

@ -289,6 +289,7 @@ namespace cxxopts
// GNU GCC with -Weffc++ will issue a warning regarding the upcoming class, we want to silence it: // GNU GCC with -Weffc++ will issue a warning regarding the upcoming class, we want to silence it:
// warning: base class 'class std::enable_shared_from_this<cxxopts::Value>' has accessible non-virtual destructor // warning: base class 'class std::enable_shared_from_this<cxxopts::Value>' has accessible non-virtual destructor
#pragma GCC diagnostic ignored "-Wnon-virtual-dtor" #pragma GCC diagnostic ignored "-Wnon-virtual-dtor"
#pragma GCC diagnostic ignored "-Weffc++"
#pragma GCC diagnostic push #pragma GCC diagnostic push
// This will be ignored under other compilers like LLVM clang. // This will be ignored under other compilers like LLVM clang.
#endif #endif