External/cxxopts
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[clang-tidy] don't use else after return

Browse Source 
Found with readability-else-after-return

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2020-05-09 17:41:32 -07:00
parent cbf8ecd4dc
commit 24678f9fee
No known key found for this signature in database
GPG Key ID: 36D31CFA845F0E3B
1 changed files with 11 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
include/cxxopts.hpp
View File

@ -901,10 +901,7 @@ namespace cxxopts
{ {
return *m_result; return *m_result;
} }
else return *m_store;
{
return *m_store;
}
} }
protected: protected:
@ -1657,10 +1654,7 @@ OptionAdder::operator()
{ {
return std::make_tuple(long_.str(), short_.str()); return std::make_tuple(long_.str(), short_.str());
} }
else return std::make_tuple(short_.str(), long_.str());
{
return std::make_tuple(short_.str(), long_.str());
}
}(short_match, long_match); }(short_match, long_match);
m_options.add_option m_options.add_option
@ -1766,22 +1760,13 @@ ParseResult::consume_positional(std::string a)
++m_next_positional; ++m_next_positional;
return true; return true;
} }
else ++m_next_positional;
{ continue;
++m_next_positional;
continue;
}
}
else
{
add_to_option(*m_next_positional, a);
return true;
} }
add_to_option(*m_next_positional, a);
return true;
} }
else throw_or_mimic<option_not_exists_exception>(*m_next_positional);
{
throw_or_mimic<option_not_exists_exception>(*m_next_positional);
}
} }
return false; return false;
@ -1882,11 +1867,8 @@ ParseResult::parse(int& argc, char**& argv)
{ {
continue; continue;
} }
else //error
{ throw_or_mimic<option_not_exists_exception>(name);
//error
throw_or_mimic<option_not_exists_exception>(name);
}
} }
auto value = iter->second; auto value = iter->second;
@ -1923,11 +1905,8 @@ ParseResult::parse(int& argc, char**& argv)
++current; ++current;
continue; continue;
} }
else //error
{ throw_or_mimic<option_not_exists_exception>(name);
//error
throw_or_mimic<option_not_exists_exception>(name);
}
} }
auto opt = iter->second; auto opt = iter->second;