External/pugixml
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add assertion about header-dest relation to strcpy_insitu

Browse Source 
May improve static analysis behavior for #555.
This commit is contained in:
Arseny Kapoulkine 2023-03-19 14:57:10 -07:00
parent 544b0a49eb
commit a469fa2cfc
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pugixml.cpp
View File

@ -2374,6 +2374,8 @@ PUGI_IMPL_NS_BEGIN
template <typename String, typename Header>
PUGI_IMPL_FN bool strcpy_insitu(String& dest, Header& header, uintptr_t header_mask, const char_t* source, size_t source_length)
{
assert((header & header_mask) == 0 || dest); // header bit indicates whether dest was previously allocated
if (source_length == 0)
{
// empty string and null pointer are equivalent, so just deallocate old memory
@ -4408,7 +4410,7 @@ PUGI_IMPL_NS_BEGIN
template <typename String, typename Header>
PUGI_IMPL_FN void node_copy_string(String& dest, Header& header, uintptr_t header_mask, char_t* source, Header& source_header, xml_allocator* alloc)
{
assert(!dest && (header & header_mask) == 0);
assert(!dest && (header & header_mask) == 0); // copies are performed into fresh nodes
if (source)
{