From 52a7981b85e3e648d11ea40cb36e4fadaac70f5e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Blissing?= <bjorn.blissing@vti.se>
Date: Mon, 28 Jun 2021 13:36:55 +0200
Subject: [PATCH] Make some compile definitions public

Moved needed defines to public section of target_compile_definitions.
---
 CMakeLists.txt | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 486cc41..0cccd98 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -98,15 +98,16 @@ if (BUILD_SHARED_LIBS)
     PUBLIC
       $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/src>)
   target_compile_definitions(pugixml-shared
-    PRIVATE
+    PUBLIC
       ${PUGIXML_BUILD_DEFINES}
-      $<$<CXX_COMPILER_ID:MSVC>:PUGIXML_API=__declspec\(dllexport\)>
       $<$<BOOL:${HAVE_LONG_LONG}>:PUGIXML_HAS_LONG_LONG>
       $<$<BOOL:${PUGIXML_WCHAR_MODE}>:PUGIXML_WCHAR_MODE>
       $<$<BOOL:${PUGIXML_COMPACT}>:PUGIXML_COMPACT>
       $<$<BOOL:${PUGIXML_NO_XPATH}>:PUGIXML_NO_XPATH>
       $<$<BOOL:${PUGIXML_NO_STL}>:PUGIXML_NO_STL>
       $<$<BOOL:${PUGIXML_NO_EXCEPTIONS}>:PUGIXML_NO_EXCEPTIONS>
+    PRIVATE
+      $<$<CXX_COMPILER_ID:MSVC>:PUGIXML_API=__declspec\(dllexport\)>
       $<$<BOOL:${PUGIXML_MEMORY_PAGE_SIZE}>:PUGIXML_MEMORY_PAGE_SIZE=${PUGIXML_MEMORY_PAGE_SIZE}>
       $<$<BOOL:${PUGIXML_MEMORY_OUTPUT_STACK}>:PUGIXML_MEMORY_OUTPUT_STACK=${PUGIXML_MEMORY_OUTPUT_STACK}>
       $<$<BOOL:${PUGIXML_MEMORY_XPATH_PAGE_SIZE}>:PUGIXML_MEMORY_XPATH_PAGE_SIZE=${PUGIXML_MEMORY_XPATH_PAGE_SIZE}>
@@ -130,7 +131,7 @@ if (NOT BUILD_SHARED_LIBS OR PUGIXML_BUILD_SHARED_AND_STATIC_LIBS)
     PUBLIC
       $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/src>)
   target_compile_definitions(pugixml-static
-    PRIVATE
+    PUBLIC
       ${PUGIXML_BUILD_DEFINES}
       $<$<BOOL:${HAVE_LONG_LONG}>:PUGIXML_HAS_LONG_LONG>
       $<$<BOOL:${PUGIXML_WCHAR_MODE}>:PUGIXML_WCHAR_MODE>
@@ -138,6 +139,7 @@ if (NOT BUILD_SHARED_LIBS OR PUGIXML_BUILD_SHARED_AND_STATIC_LIBS)
       $<$<BOOL:${PUGIXML_NO_XPATH}>:PUGIXML_NO_XPATH>
       $<$<BOOL:${PUGIXML_NO_STL}>:PUGIXML_NO_STL>
       $<$<BOOL:${PUGIXML_NO_EXCEPTIONS}>:PUGIXML_NO_EXCEPTIONS>
+    PRIVATE
       $<$<BOOL:${PUGIXML_MEMORY_PAGE_SIZE}>:PUGIXML_MEMORY_PAGE_SIZE=${PUGIXML_MEMORY_PAGE_SIZE}>
       $<$<BOOL:${PUGIXML_MEMORY_OUTPUT_STACK}>:PUGIXML_MEMORY_OUTPUT_STACK=${PUGIXML_MEMORY_OUTPUT_STACK}>
       $<$<BOOL:${PUGIXML_MEMORY_XPATH_PAGE_SIZE}>:PUGIXML_MEMORY_XPATH_PAGE_SIZE=${PUGIXML_MEMORY_XPATH_PAGE_SIZE}>